Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need better checking for damaged PRV files #38

Open
ptooley opened this issue Nov 18, 2020 · 0 comments
Open

Need better checking for damaged PRV files #38

ptooley opened this issue Nov 18, 2020 · 0 comments
Assignees
@ptooley
Labels
bug Something isn't working

Comments

@ptooley
Copy link
Contributor

ptooley commented Nov 18, 2020

Currently loading PRV files with event values outside the range of an int64 causes Pandas to silently promote the event column dtype to float. This will cause odd behaviour with e.g the OpenMP region analysis functions.

Need some way to identify this situation and warn user/error out.
@ptooley ptooley added the bug Something isn't working label Nov 18, 2020
@ptooley ptooley self-assigned this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptooley ptooley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ptooley