Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an enum for errors instead of an NonZeroI32 #782

Open
ultimaweapon opened this issue Mar 31, 2024 Discussed in #769 · 4 comments
Open

Use an enum for errors instead of an NonZeroI32 #782

ultimaweapon opened this issue Mar 31, 2024 Discussed in #769 · 4 comments
Labels
T-enhancement Type: Enhancement

Comments

@ultimaweapon
Copy link
Member

Discussed in #769

Originally posted by SuchAFuriousDeath March 27, 2024
I think this could make some functions better optimized.

@ultimaweapon ultimaweapon added the T-enhancement Type: Enhancement label Mar 31, 2024
@SuchAFuriousDeath
Copy link
Contributor

How should the enum be named? PS4Error? PS4Errno?

@ultimaweapon
Copy link
Member Author

I totally forget we already used Errno name. No idea about the name yet but we should find a better name than PS4Error and PS4Errno.

@ultimaweapon
Copy link
Member Author

We should use Errno and rename the current Errno trait to something else.

@ultimaweapon
Copy link
Member Author

My idea is AsErrno so it is matched with std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Development

No branches or pull requests

2 participants