Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to https://github.com/react-native-community? #129

Open
sibelius opened this issue Apr 16, 2020 · 10 comments
Open

move to https://github.com/react-native-community? #129

sibelius opened this issue Apr 16, 2020 · 10 comments

Comments

@sibelius
Copy link

are you willing to move to https://github.com/react-native-community?

Lightbox is great, but it is generating a bunch of warning in newer version of react-native

backend.js:32 Animated: `useNativeDriver` was not specified. This is a required option and must be explicitly set to `true` or `false` 
backend.js:32 Warning: componentWillMount has been renamed

moving there we can add more maintainers and fix all of this issues

@rarenatoe
Copy link

Shameless bump.

Does anyone know any alternatives to this clearly abandoned repository?

@Razorholt
Copy link

@renato-bvdash: No but if you do, please share :)

@cromatikap
Copy link

Hi, I made a quick patch to remove the warnings:

diff --git a/node_modules/react-native-lightbox/LightboxOverlay.js b/node_modules/react-native-lightbox/LightboxOverlay.js
index 9e01f9a..bf11c7e 100644
--- a/node_modules/react-native-lightbox/LightboxOverlay.js
+++ b/node_modules/react-native-lightbox/LightboxOverlay.js
@@ -99,7 +99,7 @@ export default class LightboxOverlay extends Component {
       onPanResponderMove: Animated.event([
         null,
         { dy: this.state.pan }
-      ]),
+      ], { useNativeDriver: false }),
       onPanResponderTerminationRequest: (evt, gestureState) => true,
       onPanResponderRelease: (evt, gestureState) => {
         if(Math.abs(gestureState.dy) > DRAG_DISMISS_THRESHOLD) {

I used patch-package.

If you want to patch it by hand, just open /node_modules/react-native-lightbox/LightboxOverlay.js and modify the line 102 to add { useNativeDriver: false } as a secondary option of Animated.event()

@azhararmar
Copy link

Sadly, there are no other library good as this. How I wish this is moved to react-native-community and maintained.

@jdegger
Copy link

jdegger commented Jun 15, 2020

Honest question: since this is licensed as MIT, is it acceptable/respected of somebody else took the code and published it to the community?

@jacquesdev
Copy link

jacquesdev commented Jul 1, 2020

Probably, but it would be more useful if @oblador agreed with this :) Does anyone know the process for this, ie to move it to community?

@cromatikap
Copy link

@jacquesdev https://github.com/react-native-community/discussions-and-proposals might be a good start to find out :)

@karimcambridge
Copy link

Please!!!

@andrescuco
Copy link

Bump. Also, if anyone knows of any up to date alternative it would be great.

@rarenatoe
Copy link

rarenatoe commented Nov 7, 2020

I ended up using react-native-image-viewing for my own very particular needs. It works very well for react native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants