Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The opam-0install-solver library unconditionally prints warnings, errors, notes #50

Open
gridbugs opened this issue Apr 28, 2023 · 0 comments

Comments

@gridbugs
Copy link

The library uses OpamConsole.warning and friends to print log messages. The problem with this is these functions print unconditionally; there is no way to set a log level and have, say, notes or warnings be suppressed. This makes it tricky to use this library in applications that want precise control over their output, like tui apps.

To fix this the library could use OpamConsole.log to print its logs as this function checks a configurable debug level before printing. Alternatively, the library could use the logs library which would give applications finer control over how and which log messages are displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant