Submit transaction

[dbuenzli]

This should be designed with #29 in mind. Sometimes you'd like to submit a set of packages in a single submission otherwise the repo may be in an inconsistant state at some commits.

Something like

opam publish submit --add PKG1
opam publish submit --add PKG2
opam publish submit --commit

[tekknolagi]

@dbuenzli do you envision this maintaining state somehow in a file? Why not just prepare/add all at once?

[dbuenzli]

Why not just prepare/add all at once?

I think it will make things painful if you need to correct and resubmit, also all at once will be difficult to solve with #29.

[tekknolagi]

Where do you propose the state is kept -- a file? Stored where?

…

On Thu, Mar 30, 2017, 00:35 Daniel Bünzli ***@***.***> wrote: Why not just prepare/add all at once? I think it will make things painful if you need to correct and resubmit, also *all at once* will be difficult to solve with #29 <#29>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYfD0iSHwNubHSCBCoqJU7nwZqxuwGOks5rq1tYgaJpZM4IMOnd> .

[dbuenzli]

Where do you propose the state is kept

I'm not proposing an implementation I'm proposing an UI.

[dbuenzli]

But given what I wrote in #29 I think a file format should be defined that allows to describe changes to an opam repo (constraints updates + paths to new packages to add) and that the tool should then consume these files to update the repo in a single commit. No state needs to be kept by opam-submit itself.

[tekknolagi]

I think it will make things painful if you need to correct and resubmit

@dbuenzli wouldn't you have ordinarily done your checks and corrections after the preparation stage? So this is just uploading a PR?

[dbuenzli]

@dbuenzli wouldn't you have ordinarily done your checks and corrections after the preparation stage? So this is just uploading a PR?

Maintainers and bots may think badly about your PR.

[tekknolagi]

So these are opam-publish transactions on PRs that already exist?

[samoht]

btw, I have started to use that workaround in mirage packages to allow multi-packages submit.

[rjbou]

As current version allows to give several packages, seems that it is resolved. Feel free to reopen if needed.
Thanks!