-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make camelus mention package owner #4897
Comments
+1
|
Cc: @AltGr I was thinking hacking this. Unfortunatly, I did not find a direct way in the github API to find the Github account associated to an email. I imagine two ways :
Obviously, the former works only for accounts that allow github to publish there email adress. Any others ideas ? |
Indeed. The question of identity of maintainers is indeed important, is anyway something that will have to sort out for signing. Gathering Github ids in advance might even help ; anyone willing to write clever git hacks to track meaningful PRs submitted to packages and extract their owner ? Using the dev-repo field is indeed a good idea, although the author may not be the maintainer... |
maybe we can start creating a |
@samoht But we already have a maintainer email field in the opam file? Why can't we just extend it to cover github usernames (among other things). My own 2 cents: I'm not a fan of scattering this information on the file system. |
To avoid the sad situation with #4896, I think @camelus should @-mention every GitHub username included in the
dev-repo
field of the packages that have been changed.And I also think it is reasonable that, unless the package was broken in an obvious way or there is no functional change, maintainers should wait a day or two before merging to give the package maintainer a chance to respond.
The text was updated successfully, but these errors were encountered: