Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make camelus mention package owner #4897

Closed
whitequark opened this issue Sep 28, 2015 · 6 comments
Closed

Make camelus mention package owner #4897

whitequark opened this issue Sep 28, 2015 · 6 comments

Comments

@whitequark
Copy link
Member

To avoid the sad situation with #4896, I think @camelus should @-mention every GitHub username included in the dev-repo field of the packages that have been changed.

And I also think it is reasonable that, unless the package was broken in an obvious way or there is no functional change, maintainers should wait a day or two before merging to give the package maintainer a chance to respond.

@avsm
Copy link
Member

avsm commented Sep 28, 2015

+1

On 28 Sep 2015, at 12:42, whitequark [email protected] wrote:

To avoid the sad situation with #4896 #4896, I think @camelus https://github.com/camelus should @-mention every GitHub username included in the dev-repo field of the packages that have been changed.

And I also think it is reasonable that, unless the package was broken in an obvious way or there is no functional change, maintainers should wait a day or two before merging.


Reply to this email directly or view it on GitHub #4897.

@ghost
Copy link

ghost commented Feb 23, 2016

Cc: @AltGr

I was thinking hacking this.

Unfortunatly, I did not find a direct way in the github API to find the Github account associated to an email. I imagine two ways :

  • listing all contributors of the project, then build our own association table (email -> account) ;
  • asking mainteners willings to have feedbacks to add a 'github' account in the opam package.

Obviously, the former works only for accounts that allow github to publish there email adress. Any others ideas ?

@AltGr
Copy link
Member

AltGr commented Feb 24, 2016

Indeed. The question of identity of maintainers is indeed important, is anyway something that will have to sort out for signing. Gathering Github ids in advance might even help ; anyone willing to write clever git hacks to track meaningful PRs submitted to packages and extract their owner ?

Using the dev-repo field is indeed a good idea, although the author may not be the maintainer...

@samoht
Copy link
Member

samoht commented Feb 24, 2016

maybe we can start creating a /maintainer subdirectory and start filling it with useful info? That'll pave the way for signing and that's already useful.

@rgrinberg
Copy link
Member

@samoht But we already have a maintainer email field in the opam file? Why can't we just extend it to cover github usernames (among other things).

My own 2 cents: I'm not a fan of scattering this information on the file system.

@dbuenzli
Copy link
Contributor

dbuenzli commented Jul 3, 2017

Closing in favour of duplicate #6819 in which @hannesm mentions he has a solution to the map between github usernames and email addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants