From 2b6e537f4e2a06603cfb62c61a2af5f471b4a699 Mon Sep 17 00:00:00 2001
From: paulo-ocean <paulo@oceanprotocol.com>
Date: Fri, 13 Dec 2024 15:19:37 +0000
Subject: [PATCH 1/3] make retries and interval bigger & configurable

---
 src/services/Aquarius.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/services/Aquarius.ts b/src/services/Aquarius.ts
index 426715ae4..3e4357572 100644
--- a/src/services/Aquarius.ts
+++ b/src/services/Aquarius.ts
@@ -59,7 +59,9 @@ export class Aquarius {
   public async waitForAqua(
     did: string,
     txid?: string,
-    signal?: AbortSignal
+    signal?: AbortSignal,
+    interval: number = 3000,
+    maxRetries: number = 100
   ): Promise<Asset> {
     let tries = 0
     do {
@@ -80,9 +82,9 @@ export class Aquarius {
       } catch (e) {
         // do nothing
       }
-      await sleep(1500)
+      await sleep(interval)
       tries++
-    } while (tries < 100)
+    } while (tries < maxRetries)
     return null
   }
 

From 6381795c957f301b93461d84a14ff59991b58738 Mon Sep 17 00:00:00 2001
From: paulo-ocean <paulo@oceanprotocol.com>
Date: Fri, 13 Dec 2024 17:19:39 +0000
Subject: [PATCH 2/3] rename waitForAqua as waitForIndexer

---
 CodeExamples.md                             |  4 ++--
 ComputeExamples.md                          |  4 ++--
 docs/classes/Aquarius.md                    | 10 ++++++----
 src/services/Aquarius.ts                    |  4 ++--
 test/integration/CodeExamples.test.ts       |  4 ++--
 test/integration/ComputeExamples.test.ts    |  4 ++--
 test/integration/ComputeFlow.test.ts        |  8 ++++----
 test/integration/PublishEditConsume.test.ts | 18 +++++++++---------
 test/integration/PublishFlows.test.ts       |  4 ++--
 9 files changed, 31 insertions(+), 29 deletions(-)

diff --git a/CodeExamples.md b/CodeExamples.md
index c9184b6e1..ef020a78d 100644
--- a/CodeExamples.md
+++ b/CodeExamples.md
@@ -504,7 +504,7 @@ Now we can make the contract call
     )
     console.log(`Consumer ${FRE_NFT_SYMBOL} balance after swap: ${consumerDTBalance}`)
 
-    const resolvedDDO = await aquarius.waitForAqua(fixedDDO.id)
+    const resolvedDDO = await aquarius.waitForIndexer(fixedDDO.id)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
 
 ```
@@ -726,7 +726,7 @@ Now we need to encrypt file(s) using provider
       `Consumer ${DISP_NFT_SYMBOL} balance after dispense: ${consumerDTBalance}`
     )
 
-    const resolvedDDO = await aquarius.waitForAqua(fixedDDO.id)
+    const resolvedDDO = await aquarius.waitForIndexer(fixedDDO.id)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
 
     datatoken = new Datatoken(consumerAccount, await consumerAccount.getChainId())
diff --git a/ComputeExamples.md b/ComputeExamples.md
index 41f5c618b..19c6bae74 100644
--- a/ComputeExamples.md
+++ b/ComputeExamples.md
@@ -539,8 +539,8 @@ Now, let's check that we successfully published a algorithm (create NFT + Datato
 
   ### 7.1 Resolve published datasets and algorithms
 ```Typescript
-    resolvedDatasetDdo = await aquariusInstance.waitForAqua(datasetId)
-    resolvedAlgorithmDdo = await aquariusInstance.waitForAqua(algorithmId)
+    resolvedDatasetDdo = await aquariusInstance.waitForIndexer(datasetId)
+    resolvedAlgorithmDdo = await aquariusInstance.waitForIndexer(algorithmId)
 ```
 <!--
     assert(resolvedDatasetDdo, 'Cannot fetch DDO from Aquarius')
diff --git a/docs/classes/Aquarius.md b/docs/classes/Aquarius.md
index 6aaf97db9..6275cd2f9 100644
--- a/docs/classes/Aquarius.md
+++ b/docs/classes/Aquarius.md
@@ -18,7 +18,7 @@
 - [querySearch](Aquarius.md#querysearch)
 - [resolve](Aquarius.md#resolve)
 - [validate](Aquarius.md#validate)
-- [waitForAqua](Aquarius.md#waitforaqua)
+- [waitForIndexer](Aquarius.md#waitForIndexer)
 
 ## Constructors
 
@@ -146,11 +146,11 @@ Validate DDO content
 
 ___
 
-### waitForAqua
+### waitForIndexer
 
-▸ **waitForAqua**(`did`, `txid?`, `signal?`): `Promise`<[`Asset`](../interfaces/Asset.md)\>
+▸ **waitForIndexer**(`did`, `txid?`, `signal?`, `interval=3000`,`maxRetries=100`): `Promise`<[`Asset`](../interfaces/Asset.md)\>
 
-Blocks until Aqua will cache the did (or the update for that did) or timeouts
+Blocks until Indexer will cache the did (or the update for that did) or timeouts
 
 #### Parameters
 
@@ -159,6 +159,8 @@ Blocks until Aqua will cache the did (or the update for that did) or timeouts
 | `did` | `string` | DID of the asset. |
 | `txid?` | `string` | used when the did exists and we expect an update with that txid. |
 | `signal?` | `AbortSignal` | abort signal |
+| `interval` | `number` | retry interval in miliseconds. Default is 3000 |
+| `maxRetries` | `number` | max number of retries. Default is 100 |
 
 #### Returns
 
diff --git a/src/services/Aquarius.ts b/src/services/Aquarius.ts
index 3e4357572..b84bdad62 100644
--- a/src/services/Aquarius.ts
+++ b/src/services/Aquarius.ts
@@ -50,13 +50,13 @@ export class Aquarius {
   }
 
   /**
-   * Blocks until Aqua will cache the did (or the update for that did) or timeouts
+   * Blocks until Indexer will cache the did (or the update for that did) or timeouts
    * @param {string} did DID of the asset.
    * @param {string} txid used when the did exists and we expect an update with that txid.
    * @param {AbortSignal} signal abort signal
    * @return {Promise<Asset>} DDO of the asset.
    */
-  public async waitForAqua(
+  public async waitForIndexer(
     did: string,
     txid?: string,
     signal?: AbortSignal,
diff --git a/test/integration/CodeExamples.test.ts b/test/integration/CodeExamples.test.ts
index 86c62f80d..aef4d79cf 100644
--- a/test/integration/CodeExamples.test.ts
+++ b/test/integration/CodeExamples.test.ts
@@ -504,7 +504,7 @@ describe('Marketplace flow tests', async () => {
     )
     console.log(`Consumer ${FRE_NFT_SYMBOL} balance after swap: ${consumerDTBalance}`)
 
-    const resolvedDDO = await aquarius.waitForAqua(fixedDDO.id)
+    const resolvedDDO = await aquarius.waitForIndexer(fixedDDO.id)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
 
     /// ```
@@ -726,7 +726,7 @@ describe('Marketplace flow tests', async () => {
       `Consumer ${DISP_NFT_SYMBOL} balance after dispense: ${consumerDTBalance}`
     )
 
-    const resolvedDDO = await aquarius.waitForAqua(fixedDDO.id)
+    const resolvedDDO = await aquarius.waitForIndexer(fixedDDO.id)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
 
     datatoken = new Datatoken(consumerAccount, await consumerAccount.getChainId())
diff --git a/test/integration/ComputeExamples.test.ts b/test/integration/ComputeExamples.test.ts
index cbfb81b30..4eb58b3ec 100644
--- a/test/integration/ComputeExamples.test.ts
+++ b/test/integration/ComputeExamples.test.ts
@@ -539,8 +539,8 @@ describe('Compute-to-data example tests', async () => {
 
   it('7.1 Resolve published datasets and algorithms', async () => {
     /// ```Typescript
-    resolvedDatasetDdo = await aquariusInstance.waitForAqua(datasetId)
-    resolvedAlgorithmDdo = await aquariusInstance.waitForAqua(algorithmId)
+    resolvedDatasetDdo = await aquariusInstance.waitForIndexer(datasetId)
+    resolvedAlgorithmDdo = await aquariusInstance.waitForIndexer(algorithmId)
     /// ```
     /// <!--
     assert(resolvedDatasetDdo, 'Cannot fetch DDO from Aquarius')
diff --git a/test/integration/ComputeFlow.test.ts b/test/integration/ComputeFlow.test.ts
index 1b5664bc0..7641e6153 100644
--- a/test/integration/ComputeFlow.test.ts
+++ b/test/integration/ComputeFlow.test.ts
@@ -348,13 +348,13 @@ describe('Compute flow tests', async () => {
   delay(10000)
 
   it('should resolve published datasets and algorithms', async () => {
-    resolvedDdoWith5mTimeout = await aquarius.waitForAqua(ddoWith5mTimeoutId)
+    resolvedDdoWith5mTimeout = await aquarius.waitForIndexer(ddoWith5mTimeoutId)
     assert(resolvedDdoWith5mTimeout, 'Cannot fetch DDO from Aquarius')
-    resolvedDdoWithNoTimeout = await aquarius.waitForAqua(ddoWithNoTimeoutId)
+    resolvedDdoWithNoTimeout = await aquarius.waitForIndexer(ddoWithNoTimeoutId)
     assert(resolvedDdoWithNoTimeout, 'Cannot fetch DDO from Aquarius')
-    resolvedAlgoDdoWith5mTimeout = await aquarius.waitForAqua(algoDdoWith5mTimeoutId)
+    resolvedAlgoDdoWith5mTimeout = await aquarius.waitForIndexer(algoDdoWith5mTimeoutId)
     assert(resolvedAlgoDdoWith5mTimeout, 'Cannot fetch DDO from Aquarius')
-    resolvedAlgoDdoWithNoTimeout = await aquarius.waitForAqua(algoDdoWithNoTimeoutId)
+    resolvedAlgoDdoWithNoTimeout = await aquarius.waitForIndexer(algoDdoWithNoTimeoutId)
     assert(resolvedAlgoDdoWithNoTimeout, 'Cannot fetch DDO from Aquarius')
   })
 
diff --git a/test/integration/PublishEditConsume.test.ts b/test/integration/PublishEditConsume.test.ts
index 25c3fde02..22ac5b627 100644
--- a/test/integration/PublishEditConsume.test.ts
+++ b/test/integration/PublishEditConsume.test.ts
@@ -304,19 +304,19 @@ describe('Publish consume test', async () => {
   delay(10000) // let's wait for aquarius to index the  assets
 
   it('Resolve published assets', async () => {
-    resolvedUrlAssetDdo = await aquarius.waitForAqua(urlAssetId)
+    resolvedUrlAssetDdo = await aquarius.waitForIndexer(urlAssetId)
     assert(resolvedUrlAssetDdo, 'Cannot fetch url DDO from Aquarius')
 
-    resolvedArweaveAssetDdo = await aquarius.waitForAqua(arweaveAssetId)
+    resolvedArweaveAssetDdo = await aquarius.waitForIndexer(arweaveAssetId)
     assert(resolvedArweaveAssetDdo, 'Cannot fetch arwave DDO from Aquarius')
 
-    resolvedIpfsAssetDdo = await aquarius.waitForAqua(ipfsAssetId)
+    resolvedIpfsAssetDdo = await aquarius.waitForIndexer(ipfsAssetId)
     assert(resolvedIpfsAssetDdo, 'Cannot fetch ipfs DDO from Aquarius')
 
-    resolvedOnchainAssetDdo = await aquarius.waitForAqua(onchainAssetId)
+    resolvedOnchainAssetDdo = await aquarius.waitForIndexer(onchainAssetId)
     assert(resolvedOnchainAssetDdo, 'Cannot fetch onchain DDO from Aquarius')
 
-    resolvedGraphqlAssetDdo = await aquarius.waitForAqua(grapqlAssetId)
+    resolvedGraphqlAssetDdo = await aquarius.waitForIndexer(grapqlAssetId)
     assert(resolvedGraphqlAssetDdo, 'Cannot fetch graphql DDO from Aquarius')
   })
 
@@ -557,19 +557,19 @@ describe('Publish consume test', async () => {
     delay(10000) // let's wait for aquarius to index the updated ddo's
 
     it('Should resolve updated datasets', async () => {
-      resolvedUrlAssetDdoAfterUpdate = await aquarius.waitForAqua(urlAssetId)
+      resolvedUrlAssetDdoAfterUpdate = await aquarius.waitForIndexer(urlAssetId)
       assert(resolvedUrlAssetDdoAfterUpdate, 'Cannot fetch url DDO from Aquarius')
 
-      resolvedArweaveAssetDdoAfterUpdate = await aquarius.waitForAqua(arweaveAssetId)
+      resolvedArweaveAssetDdoAfterUpdate = await aquarius.waitForIndexer(arweaveAssetId)
       assert(resolvedArweaveAssetDdoAfterUpdate, 'Cannot fetch arwave DDO from Aquarius')
       // To be fixed in #1849
       // resolvedIpfsAssetDdoAfterUpdate = await aquarius.waitForAqua(ipfsAssetId)
       // assert(resolvedIpfsAssetDdoAfterUpdate, 'Cannot fetch ipfs DDO from Aquarius')
 
-      resolvedOnchainAssetDdoAfterUpdate = await aquarius.waitForAqua(onchainAssetId)
+      resolvedOnchainAssetDdoAfterUpdate = await aquarius.waitForIndexer(onchainAssetId)
       assert(resolvedOnchainAssetDdoAfterUpdate, 'Cannot fetch onchain DDO from Aquarius')
 
-      resolvedGraphqlAssetDdoAfterUpdate = await aquarius.waitForAqua(grapqlAssetId)
+      resolvedGraphqlAssetDdoAfterUpdate = await aquarius.waitForIndexer(grapqlAssetId)
       assert(resolvedGraphqlAssetDdoAfterUpdate, 'Cannot fetch onchain DDO from Aquarius')
     })
   })
diff --git a/test/integration/PublishFlows.test.ts b/test/integration/PublishFlows.test.ts
index dc2955e0a..b556ee2dc 100644
--- a/test/integration/PublishFlows.test.ts
+++ b/test/integration/PublishFlows.test.ts
@@ -223,7 +223,7 @@ describe('Publish tests', async () => {
   })
 
   it('should resolve the fixed price dataset', async () => {
-    const resolvedDDO = await aquarius.waitForAqua(fixedPricedDID)
+    const resolvedDDO = await aquarius.waitForIndexer(fixedPricedDID)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
   }).timeout(40000)
 
@@ -316,7 +316,7 @@ describe('Publish tests', async () => {
   delay(19000)
 
   it('should resolve the free dataset', async () => {
-    const resolvedDDO = await aquarius.waitForAqua(dispenserDID)
+    const resolvedDDO = await aquarius.waitForIndexer(dispenserDID)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
   })
 })

From a2371370bc5795971347ba6d46be290cf9bb4862 Mon Sep 17 00:00:00 2001
From: paulo-ocean <paulo@oceanprotocol.com>
Date: Mon, 16 Dec 2024 14:10:37 +0000
Subject: [PATCH 3/3] add a cap on the max retries to avoid any abuse

---
 src/services/Aquarius.ts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/services/Aquarius.ts b/src/services/Aquarius.ts
index b84bdad62..6aa8c5dc5 100644
--- a/src/services/Aquarius.ts
+++ b/src/services/Aquarius.ts
@@ -64,6 +64,11 @@ export class Aquarius {
     maxRetries: number = 100
   ): Promise<Asset> {
     let tries = 0
+    // lets have a cap to prevent possible abuse as well
+    if (maxRetries > 500) {
+      LoggerInstance.warn('Max Limit exceeded, defaulting to 500 retries.')
+      maxRetries = 500
+    }
     do {
       try {
         const path = this.aquariusURL + '/api/aquarius/assets/ddo/' + did