Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change instr-list endpoint #193

Closed
wants to merge 1 commit into from
Closed

Conversation

dsavchenko
Copy link
Member

Fixes #189

There are also either /api/meta-data or /meta-data endpoints in dispather, which are currently equivalent. Is one meant to be deprecated?

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #193 (e9a8ffd) into master (1e6f480) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   54.43%   54.61%   +0.17%     
==========================================
  Files          20       20              
  Lines        3926     3926              
==========================================
+ Hits         2137     2144       +7     
+ Misses       1789     1782       -7     
Impacted Files Coverage Δ
oda_api/api.py 76.62% <100.00%> (ø)
tests/conftest.py 88.46% <0.00%> (+7.69%) ⬆️
tests/test_plot_tools.py 100.00% <0.00%> (+10.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@burnout87
Copy link
Collaborator

burnout87 commented Feb 24, 2023

There are also either /api/meta-data or /meta-data endpoints in dispather, which are currently equivalent. Is one meant to be deprecated?

The redirection was introduced with oda-hub/dispatcher-app#513

But /api/meta-data or /meta-data were not touched

@dsavchenko dsavchenko closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

due to deprecation of /api/instr-list in dispatcher, oda-api can't get list of instruments
2 participants