Support max_active_channels #500
Conversation
|
Tested a few images from idr0076 and idr0158 on idr-testing. Works well, max 10 channels message appears when trying to click on channel 11. Perhaps include in the message that you have to deselect a channel before you can reselect a channel. |
|
Tested on idr-testing with idr0076 and idr0158. Wfm and I am happy with the level of messaging. |
|
Other settings are described in the README |
|
For comparison, Pathviewer message is "Cannot activate channel, maximum number of channels already active".
|
|
Now looks like this:
|
|
@will-moore On Pathviewer, they also have a count of the active channels with the maximum number stated, which can be useful and helps to make max channel number clear. Not sure if this is something we would also like to have. |
|
@francesw That's kinda nice, but I would prefer not to add it as it's a fair bit more work, unless it's really required? |
|
@will-moore The counter is possibly also relatively new from Pathviewer as I don't recall seeing it a few months ago, hence they may have also updated the max channel message accordingly. But, yes, if it's a fair bit more work, then we can leave it, it's not required. Thanks |
|
Discussed with @will-moore. My comment about the description of the configuration will be fixed in a follow up PR. |
Fixes #472
This turns off all channels over the
max_active_channelslimit when the image loads and also prevents the user from turning on more channels than this limit. Use will see a message E.g. "The maximum number of active channels is 10."When microservices are not available, we use a default value for max_active_channels.
This can be configured with:
But what should the default value be if without the user setting anything?
Currently we don't limit the active channels, so to maintain that behaviour, we could set the value quite high, e.g. 50.
I seem to remember that saving rendering settings fails for around 60+ channels.
Or we go for 10 (same as microservices) or a bit higher, e.g. 20?