Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NGINX example load balancer of a gateway collector deployment #4376

Closed
oCHRISo opened this issue Apr 27, 2024 · 4 comments · May be fixed by #5988
Closed

Fix NGINX example load balancer of a gateway collector deployment #4376

oCHRISo opened this issue Apr 27, 2024 · 4 comments · May be fixed by #5988
Labels
bug Something isn't working

Comments

@oCHRISo
Copy link

oCHRISo commented Apr 27, 2024

What needs to be changed?

Within the gateway page, the NGINX configuration within NGINX as an "out-of-the-box" load balancer examples section is incorrect. The example highlights three collectors (collector1, collector2, and collector) but within the NGINX configuration, only collector1 and collector2 are upstream. All 3 collectors are required to be in the upstream.

What is the name + path of the page that needs changed?

Path: content/en/docs/collector/deployment/gateway.md
Title: Gateway

Additional context:
@oCHRISo oCHRISo added the bug Something isn't working label Apr 27, 2024
@svrnm
Copy link
Member

svrnm commented Apr 29, 2024

I think it should be collector1, collector2 and collector3 right? But beyond that, I agree. Are you willing to create a PR for that (note that we require contributors to sign a CLA)?

@oCHRISo
Copy link
Author

oCHRISo commented Apr 29, 2024

Yes that's correct and I'm happy to do a PR to address. Thanks for your reply

oCHRISo added a commit to oCHRISo/opentelemetry.io that referenced this issue Apr 29, 2024
@oCHRISo
Fixes open-telemetry#4376
8b8b958
@oCHRISo oCHRISo mentioned this issue Apr 29, 2024
Closed
@meswapnilk meswapnilk mentioned this issue Jan 20, 2025
Open
@meswapnilk
Copy link
Contributor

Added fresh PR for the issue

@svrnm
Copy link
Member

svrnm commented Jan 20, 2025

thanks for the PR @meswapnilk , but it seems this has been fixed already here:

#5283

@svrnm svrnm closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@svrnm @oCHRISo @meswapnilk