Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move batch from ocf-datapipes #65

Closed
Tracked by #58
peterdudfield opened this issue Oct 13, 2024 · 3 comments
Closed
Tracked by #58

move batch from ocf-datapipes #65

peterdudfield opened this issue Oct 13, 2024 · 3 comments

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Oct 13, 2024

I wonder if we should move ocf-datapipes batch into this repo for the moment.
We could use Batch.gsp.name here and similar other place, to use a string not a Enum. The Enum we have had problems in the past, when we change the.

Later on we can add a Batch class with load, save, plot methods e.t.c TODO make issue

@peterdudfield peterdudfield mentioned this issue Oct 13, 2024
3 tasks
@peterdudfield peterdudfield changed the title batch move batch from ocf-datapipes Oct 13, 2024
@Sukh-P
Copy link
Member

Sukh-P commented Oct 21, 2024

Happy to pick this one up and create the issue for the Batch class

@peterdudfield
Copy link
Contributor Author

Shall we put this as done and create a new issue saying "create batch class"?

@Sukh-P
Copy link
Member

Sukh-P commented Oct 21, 2024

Created the new issues here #71

@Sukh-P Sukh-P closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants