Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

test #886

Closed
wants to merge 31 commits into from
Closed

test #886

wants to merge 31 commits into from

Conversation

colinbrash
Copy link

Anyone merging to this repository is expected to promptly release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Description

Supporting information

Testing instructions

Other information

Checklist

  • Consider PCI compliance impact and whether this PR changes how credit card information is handled.
  • Intend to release and monitor this PR promptly after merge.

christopappas and others added 30 commits April 5, 2024 13:30
@christopappas
docs: updating readme (#1)
b2de60b 
* docs: updating readme

* chore: changing text to trigger GHA

* fix: update CODEOWNERS to be internal revenue-squad
@julianajlk
refactor: Add shipping address for Afterpay, PaymentIntentUnexpectedS…
bdb2358 
…tateError, WIP
@julianajlk
feat: Add DynamicPaymentMethodsNotCompatibleError to handle BNPL DPM …
3f144a9 
…on unsupported countries
@julianajlk
refactor: Postal code required for BNPL DPM supported countries since…
a25976a 
… API expects it
@julianajlk
fix: Update stripe checkout function
4529662
@julianajlk
refactor: Get paymentMethodType onChange and send shipping address on…
a8dddd2 
…ly if afterpay
@julianajlk
feat: Add PaymentMethodMessagingElement, modify currencySelector, use…
7d2222c 
… prod-edx-cf-loc
@julianajlk
refactor: Modify checkout function to handleNextAction for DPM payments
9c00e5f
@julianajlk
fix: Add isPaymentRedirect to selectors for redirect to receipt
eaaed95
@julianajlk
refactor: Modify PaymentPage to account for redirect from DPM and red…
a641b79 
…irect to receipt
@julianajlk
refactor: Use stripe promise from PaymentPage parent in Checkout
ee959b4
@julianajlk
fix: Update invalid_request_error to include error in missing state a…
9b81cc0 
…nd zip code
@julianajlk
fix: Only Klarna has redirect_status on return_url, cannot rely on it
fd2bccc
@julianajlk
fix: Remove no longer needed PaymentIntentUnexpectedStateError, handl…
0a8c584 
…ing from BE instead
@julianajlk
fix: Reorder error type in handleRequestError from feedback
521c606
@julianajlk
test: Add more tests
e1b548d
@julianajlk
fix: Add dpm_enabled query param to receipt URL
b60c260
@julianajlk
fix: Add stripeSelectedPaymentMethod to payment_selected click event
7fa34ad
@julianajlk
Merge pull request #4 from edx/julianajlk/REV-3830/stripe-dpm
85e5f51 
REV-3830
@julianajlk
fix: Add country compatibility with BNPL Affirm at the form level (#5)
d71837f 
REV-3830
@julianajlk
refactor: DPM loading lag for successful payments redirect (#6)
83a63fc 
REV-4009
@julianajlk
chore: Clean up allowlist follow-redirects and webpack-dev-middleware (…
2c35546 
…#9)

REV-3951
@julianajlk
refactor: Reorder DPM successful loading redirect (#8)
0de1892 
REV-4009
@julianajlk
fix: Remove DPM Canada form validation (#10)
bc3becb
@julianajlk
feat: Add PageLoadingDynamicPaymentMethods with timeout for DPM recei…
4aeb2f5 
…pt redirect (#11)

REV-4049
@christopappas
feat: remove cybersource script (#7)
5a61584
@grmartin @julianajlk
@christopappas @bdizha
feat: added paypal param redirect (#13)
69836b7 
* feat: Added  paypal redirect (#11)

REV-4049

* feat: remove cybersource script (#7)

* fix: Added paypal redirect feature triggered buy the frontastic checkout

* fix: commit message

* fix: resolved new function referencing

* fix: Updated a typo

* feat: Added new paypal payment redirect test coverage

* fix: removed duplicate function

* fix: paypal redirect to only happen once

---------

Co-authored-by: Juliana Kang <[email protected]>
Co-authored-by: Chris Pappas <[email protected]>
Co-authored-by: Batanayi Matuku <[email protected]>
Co-authored-by: Batanayi Matuku <[email protected]>
@NawfalAhmed
feat: disable wallets in stripe payment form (#14)
7446be2
@julianajlk
fix: Disable B2C subscriptions default configs (#15)
23f7000
@christopappas
[chore] Delete openedx.yaml
5c1383b 
this repo isnt in openedx, so we dont need this file
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @colinbrash!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@colinbrash colinbrash closed this Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@colinbrash @openedx-webhooks @christopappas @Silidrone @julianajlk @grmartin @NawfalAhmed @shafqatfarhan