Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enzyme testing replaced by react tester #36026

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jciasenza
Copy link
Contributor

Replaced enzyme display dropdown on toggling dropdown test in Main file for react-renderer tests.

I made PR of this issue #35245

And Testing OK

If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 12, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 12, 2024

Thanks for the pull request, @jciasenza!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 17, 2024
@kdmccormick kdmccormick self-requested a review January 13, 2025 18:40
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It's awesome to see enzyme tests replaced!

Would it be possible to use userEvent instead of fireEvent for these? It is recommended by testing-library, and the differences are described here: https://testing-library.com/docs/user-event/intro/#differences-from-fireevent

fireEvent dispatches DOM events, whereas user-event simulates full interactions, which may fire multiple events and do additional checks along the way.

A lot of the time moving to userEvent from fireEvent is very straightforward. It looks like that is likely the case with here.

@jciasenza
Copy link
Contributor Author

jciasenza commented Jan 13, 2025

Hi @brian-smith-tcril, I'll try it and let you know!!
I made the change, please review !!!

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jciasenza , it looks like the edited test case is failing. If you click into "Javascript tests / JS" check below, you should be able to see how it is failing. If you have a development environment set up, you could also run the tests locally with jest.

@brian-smith-tcril
Copy link
Contributor

It looks like the error is

    Cannot find module '@testing-library/react' from 'lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx'

so I think adding the testing library packages as dev dependencies should resolve this.

@jciasenza
Copy link
Contributor Author

Yes @brian-smith-tcril , that is the error but apparently the version of React is 16 and I am looking for the compatible version for @testing-library/react and @testing-library/user-event

@brian-smith-tcril
Copy link
Contributor

Yes @brian-smith-tcril , that is the error but apparently the version of React is 16 and I am looking for the compatible version for @testing-library/react and @testing-library/user-event

From https://www.npmjs.com/package/@testing-library/react/v/14.3.1

React Testing Library versions 13+ require React v18. If your project uses an older version of React, be sure to install version 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

5 participants