Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken re-run notification dismiss #1590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Jan 14, 2025

Description

When you re-run a course:
image

You see this notification:
image

If you click the "Dismiss" button, in the "Network" tab of your browser dev tools you can see this:
image

This DELETE request has no effect, because needs to be sent to Studio instead. If you re-load the page - the notification will still be there.

This PR fixes this by prefixing notification_dismiss_url that we get from the backend with the Studio base URL.

Testing instructions

A dismissed notification shouldn't re-appear after page reload.

internal reference

@0x29a 0x29a requested a review from a team as a code owner January 14, 2025 16:18
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 14, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @0x29a!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (8385c4e) to head (b2bef7e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files        1092     1092           
  Lines       21617    21617           
  Branches     4577     4578    +1     
=======================================
  Hits        20120    20120           
  Misses       1431     1431           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0x29a added a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 14, 2025
(cherry picked from pull request openedx#1590)
0x29a added a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 14, 2025
(cherry picked from pull request openedx#1590)
@Cup0fCoffee
Copy link
Contributor

@0x29a LGTM! I've tested the changes, and they are working as described. The only edge case I found, is that if you're not logged into studio, the request fails, but it might be outside of the current scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants