-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken re-run notification dismiss #1590
base: master
Are you sure you want to change the base?
fix: broken re-run notification dismiss #1590
Conversation
Thanks for the pull request, @0x29a! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1590 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 1092 1092
Lines 21617 21617
Branches 4577 4578 +1
=======================================
Hits 20120 20120
Misses 1431 1431
Partials 66 66 ☔ View full report in Codecov by Sentry. |
(cherry picked from pull request openedx#1590)
(cherry picked from pull request openedx#1590)
@0x29a LGTM! I've tested the changes, and they are working as described. The only edge case I found, is that if you're not logged into studio, the request fails, but it might be outside of the current scope. |
Description
When you re-run a course:
You see this notification:
If you click the "Dismiss" button, in the "Network" tab of your browser dev tools you can see this:
This
DELETE
request has no effect, because needs to be sent to Studio instead. If you re-load the page - the notification will still be there.This PR fixes this by prefixing notification_dismiss_url that we get from the backend with the Studio base URL.
Testing instructions
A dismissed notification shouldn't re-appear after page reload.
internal reference