chore: update sidebar logic

[leangseu-edx]

https://2u-internal.atlassian.net/browse/AU-1552

1. If a course has an upgrade option, it will automatically open whenever the page is refreshed.
2. If a course has already been upgraded, it will behave as it used to
   1. Open discussion board when available
   2. Else don't open the sidebar

After Fix

Desktop

Mobile

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (748e73d) 87.46% compared to head (2d28236) 87.30%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/data/sessionStorage.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
- Coverage   87.46%   87.30%   -0.17%     
==========================================
  Files         275      275              
  Lines        4723     4717       -6     
  Branches     1193     1190       -3     
==========================================
- Hits         4131     4118      -13     
- Misses        575      580       +5     
- Partials       17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ayub02]

@leangseu-edx Does this PR also resolve the issue where notifications sidebar would open but no notifications were present in the sidebar?

[Not a blocker for this PR] Also, can you please share any details on following:

1. On what course units, is a notification intended to appear? Afaik, it didn't appear on all units before march 2023.
2. How can we create a notification for testing?

cc: @awais-ansari @asadazam93 @mattcarter

[awais-ansari]

@leangseu-edx This change will show the notification tray on mobile full-screen in every unit. It will be disturbing for mobile users to close the notification tray first in every unit to see the content. Is this expected behavior?
Other than this change is LGTM.

[awais-ansari]

@leangseu-edx Does this PR also resolve the issue where notifications sidebar would open but no notifications were present in the sidebar?

[Not a blocker for this PR] Also, can you please share any details on following:

1. On what course units, is a notification intended to appear? Afaik, it didn't appear on all units before march 2023.
2. How can we create a notification for testing?

cc: @awais-ansari @asadazam93 @mattcarter

@ayub02 Notification try will be visible on every unit, if the course is not upgraded.

[leangseu-edx]

@leangseu-edx This change will show the notification tray on mobile full-screen in every unit. It will be disturbing for mobile users to close the notification tray first in every unit to see the content. Is this expected behavior? Other than this change is LGTM.

This is also the current behavior for discussion. I also agree that it shouldn't do that in mobile view but I would rather keep the behavior consistent for now.

[mattcarter]

approved