Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable tinymce plugins #436

Merged

Conversation

jesperhodge
Copy link
Member

@jesperhodge jesperhodge commented Dec 14, 2023

We have observed errors in the Editor when developing locally when the plugins are enabled. They do not occur on stage or prod for us, but we have a theory that they will occur when the openedx stubbed version of the plugins is used. So we will disable for now and work on a fix.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbd3d85) 90.55% compared to head (079ff01) 90.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files         227      227           
  Lines        4120     4120           
  Branches      831      831           
=======================================
  Hits         3731     3731           
  Misses        369      369           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bszabo bszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesperhodge jesperhodge merged commit 56ffc49 into main Dec 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants