Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable user retirement sink #544

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: enable user retirement sink #544

merged 2 commits into from
Jan 11, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Dec 15, 2023

Description

This PR adds the retirement sink to the default PII models and models

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 15, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/enable-user-retirement branch from 90f0d54 to dde6f1c Compare December 15, 2023 20:36
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Dec 21, 2023
@Ian2012 Ian2012 force-pushed the cag/enable-user-retirement branch from dde6f1c to 4332e05 Compare January 10, 2024 13:56
pomegranited
pomegranited approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works for me too :)

  • I tested this on my Tutor dev stack
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation

@Ian2012 Ian2012 merged commit 5fe95ce into main Jan 11, 2024
6 checks passed
@Ian2012 Ian2012 deleted the cag/enable-user-retirement branch January 11, 2024 14:48
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

@pomegranited pomegranited pomegranited approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ian2012 @openedx-webhooks @pomegranited @bmtcril @itsjeyd