Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Moving MVs to dbt caused them to be materialized to the wrong schema #561

Closed
bmtcril opened this issue Jan 11, 2024 · 4 comments
Closed
Labels
bug Report of or fix for something that isn't working as intended

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Jan 11, 2024

We need to fix up the dbt project so that the MVs we had in the xapi schema go back there. We should be able to do this by doing the following:

It's also possible to simply override the database using the env var like we do here: https://github.com/openedx/aspects-dbt/blob/d0b59458faf368b51ad8b6d44bce75ab895e6ee8/models/completion/schema.yml#L5

More info: https://docs.getdbt.com/docs/build/custom-schemas

@bmtcril bmtcril added bug Report of or fix for something that isn't working as intended aspects v1 labels Jan 11, 2024
@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 11, 2024

@SoryRawyer just giving you a heads up on this one

@SoryRawyer
Copy link
Contributor

My apologies for overlooking this. As far as I know, the MVs and tables that should go into the ASPECTS_XAPI_DATABASE schema are listed here: https://github.com/openedx/tutor-contrib-aspects/blob/main/tutoraspects/plugin.py#L81-L97
Am I forgetting anything?

@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 11, 2024

@SoryRawyer seems right to me

@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 12, 2024

Fixed by:
openedx/aspects-dbt#39
#562

@bmtcril bmtcril closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants