Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn datasets into virtual #651

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat: turn datasets into virtual #651

merged 2 commits into from
Mar 13, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Mar 13, 2024

Description

This PR turns every dataset into a virtual dataset. It also re-serialize the assets to exclude unnecessary fields

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 13, 2024
@Ian2012 Ian2012 force-pushed the cag/virtual-datasets branch from 7f96bef to 3fee1de Compare March 13, 2024 18:32
@Ian2012 Ian2012 force-pushed the cag/virtual-datasets branch from 3fee1de to 6ee7857 Compare March 13, 2024 18:34
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I haven't been able to test it but it seems reasonable.

@Ian2012 Ian2012 merged commit 1d6e9d5 into main Mar 13, 2024
10 checks passed
@Ian2012 Ian2012 deleted the cag/virtual-datasets branch March 13, 2024 19:36
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants