olive-testing TC_AUTHOR_53: all text block types

[ARMBouhali]

Passing tests:

• Text
• Announcement
• Anonymous User ID
• IFrame Tool
• Raw HTML
• Zooming Image Tool 🔴 cross-tested by @DeanJayMathew

[ARMBouhali]

• IFrame Tool : sometimles not loading content. instead a few characters appear at the top-left of the iframe:

[ARMBouhali]

• Zooming Image Tool: Magnifier not showing in LMS.

1. Mouse cursor is pointer (like for links).
2. Clicking on the image opens it in a new tab.

Update 1: The component works in Studio perfectly. The issue happens only in LMS.
I've tested the block alone in a single unit and I'm getting the following browser console error:

Uncaught ReferenceError: JavascriptLoader is not defined
at block-v1:edX+DemoX+Demo_Course+type@vertical+block@50d100ba01dc4b47a17d0986f36bd106?show_title=0&show_bookmark_button=0&recheck_access=1&view=student_view:329:1

[DeanJayMathew]

@ARMBouhali for me the Iframe is working: https://apps.olive.demo.overhang.io/learning/course/course-v1:PRIVATE+mineminemine+whataboutsmee/block-v1:PRIVATE+mineminemine+whataboutsmee+type@sequential+block@513f5e52d8384024a09f72e13438f02e/block-v1:PRIVATE+mineminemine+whataboutsmee+type@vertical+block@ada4ca4f10cf4caeb939818f3aadffa7

[DeanJayMathew]

@ARMBouhali for me the zooming image tool is also not working in the LMS view.

[ARMBouhali]

@ARMBouhali for me the Iframe is working

@dean The iframe is probably working as you have seen but the default xBlock iframe content is probably what's not loading consistently (sometimes loaded, most of the time not loading).
Can anyone please confirm that?

[DeanJayMathew]

@ARMBouhali the iFrame issue is displaying correctly for me (please see Studio and LMS view:

[ARMBouhali]

@DeanJayMathew When I do duplicates of the same block, the iframe content randomly loads or not.
What I think:

• Either there is a throttle rate on the iframe source from edx.org, which makes it appear inconsistently.
• Or this error with HTTP iframe options is the source of the problem.
  

The iframe is an old reliable HTTP concept we cannot blame, so there are 3 possibilities I see ahead:

• We agree that the block works regardless of the issue with the iframe source.
• We ask edx.org people if they can fix iframe options for eulerLineDemo.html then retry after that.
• We test the same eulerLineDemo.html as part of edx-platform or as a course upload, or wherever CORS and iframe options are less restrictive. Then if it works, we do an edx-platform PR for it.

[DeanJayMathew]

Great bug hunting! If the issue is just appearing when duplicating the component, then this issue is just cosmetic. Since course teams will edit the component with their own image anyway it's not a showstopper neither is it a #ReleaseBlocker. What about doing Option 1 for Olive.1. Then trying to do Option 2 or Option 3 (to be decided by way of BTR consensus) for Olive.2 or incase of any delay we can do it for Palm.1 - 1. We agree that the block works regardless of the issue with the iframe source. - 2. We ask edx.org people if they can fix iframe options for eulerLineDemo.html then retry after that. - 3. We do an edx-platform PR to propose a different iframe source or to provide a hosted version of the same eulerLineDemo.html. Anyone else have any thoughts on this?

…

On Wed, 7 Dec 2022, 15:24 Abderraouf Mehdi Bouhali, < ***@***.***> wrote: @DeanJayMathew <https://github.com/DeanJayMathew> When I do duplicates of the same block, the iframe content randomly loads or not. What I think: - Either there is a throttle rate on the iframe source from edx.org, which makes it appear inconsistently. - Or this error with HTTP iframe options is the source of the problem. [image: image] <https://user-images.githubusercontent.com/10594967/206124798-bd7da7b7-c53d-4f50-bb0a-18c96eada0f5.png> The iframe is an old reliable HTTP concept we cannot blame, so there are 3 possibilities I see ahead: - We agree that the block works regardless of the issue with the iframe source. - We ask edx.org people if they can fix iframe options for eulerLineDemo.html then retry after that. - We do an edx-platform PR to propose a different iframe source or to provide a hosted version of the same eulerLineDemo.html. — Reply to this email directly, view it on GitHub <#208 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACMGDW6O3QMVR27V7SMHFCTWMBCTLANCNFSM6AAAAAARNE7KVM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ARMBouhali]

I updated the comment for zooming image tool above

Update 1: The component works in Studio perfectly. The issue happens only in LMS. I've tested the block alone in a single unit and I'm getting the following browser console error:

Uncaught ReferenceError: JavascriptLoader is not defined
at block-v1:edX+DemoX+Demo_Course+type@vertical+block@50d100ba01dc4b47a17d0986f36bd106?show_title=0&show_bookmark_button=0&recheck_access=1&view=student_view:329:1

This one is definitely not working. I don't think we can close the issue until it is solved.
We probably need to debug this in dev. But I don't have the time to do so for now.

[arbrandes]

The zoom tool is not working in a devstack either. It is also unsupported upstream (note the warning at the top), and is not even listed in the HTML block documentation.

I couldn't get it to work after tweaking the HTML a bit, either. I suspect the recent conversion from XModule to XBlock that affected the HTML block (among others) also changed the way they're rendered in the LMS, which would explain this. But it also means fixing it would be... complicated.

We can open an issue upstream, but I very much doubt it'll ever get fixed except maybe by the removal of the template altogether. We have 3 options:

1. Open an issue upstream, and make a known issue note in the Release Notes.
2. Open a PR to remove the template upstream, and hope it gets merged/backported before release. (Unlikely.)
3. Have Tutor remove the file during its build process. (Ugly.)

I vote for 1. Objections?

[ARMBouhali]

@arbrandes Good to know the zooming image tool is not supported.

• Open an issue upstream, and make a known issue note in the Release Notes.

I'm in favor of applying this to both the zooming image tool and the iframe tool as it means fewer immediate changes and more time to either work on a fix or decide to drop off the list.

Waiting for others to express what they think, before I update the checklist and close the issue (someone has to notify me of the consensus, of course)

[DeanJayMathew]

@arbrandes @ARMBouhali no objections from me.

Back in 2014/15 when I first started using the Open edX® platform I thought the zooming image tool was fantastic. However, we've never used it in all these years. A use case has never come up for us. I still like the tool though.

[arbrandes]

@pdpinch, we'll need to add a Known Issue in the Release Notes for the broken Zoom Tool. (The iframe tool seems to be fine for regular usage.)

[arbrandes]

Created the upstream issue with an accompanying PR. The release notes author was informed above. We can close this.