Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: cuIBM: A GPU-based immersed boundary method code #292

Closed
whedon opened this issue Jun 12, 2017 · 10 comments
Closed

[PRE REVIEW]: cuIBM: A GPU-based immersed boundary method code #292

whedon opened this issue Jun 12, 2017 · 10 comments
Assignees

Comments

@whedon
Copy link

whedon commented Jun 12, 2017

Submitting author: @mesnardo (Olivier Mesnard)
Repository: https://github.com/barbagroup/cuIBM
Version: v0.1
Editor: @kyleniemeyer
Reviewer: @arghdos

Author instructions

Thanks for submitting your paper to JOSS @mesnardo. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@mesnardo if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 12, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @kyleniemeyer it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@kyleniemeyer
Copy link

Hi @mesnardo, thanks for submitting cuIBM to JOSS!

(For full disclosure, I've encountered cuIBM before; one of my students forked it and developed his own methods using that. However, I haven't contributed to cuIBM itself.)

Where possible, I like to find two reviewers: one close to the domain, and another perhaps coming from a bit further away.

@boyceg @namupatel and/or @arghdos, would you be willing to review this submission to JOSS? @mesnardo, any other suggestions you have would also be appreciated.

@mesnardo
Copy link

mesnardo commented Jun 21, 2017

Hi @kyleniemeyer , thank you for being the editor for this paper.

I just released version 0.1.1 of cuIBM that includes a small bug-fix: downgrading the external library yaml-cpp from version 0.5.3 to 0.5.1.
(yaml-cpp is bundled into cuIBM, in the external folder.)
With version 0.5.3, yaml-cpp throws an error when a key parameter is not present in the YAML configuration file, whereas the expected behavior is to use the default value for the parameter.

So, the reviewers should be using the master branch of cuIBM or the release 0.1.1.

@skyreflectedinmirrors
Copy link

@kyleniemeyer I'm willing to review this

@kyleniemeyer
Copy link

kyleniemeyer commented Jun 21, 2017

Awesome, thanks @arghdos! Dan Magee (@OSUmageed) has also agreed to serve as a second reviewer.

@kyleniemeyer
Copy link

@whedon assign @arghdos as reviewer

@whedon
Copy link
Author

whedon commented Jun 21, 2017

OK, the reviewer is @arghdos

@kyleniemeyer
Copy link

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Jun 21, 2017

OK, I've started the review over in #301. Feel free to close this issue now!

@kyleniemeyer
Copy link

OK @arghdos @OSUmageed and any others following, we'll move over to #301 for the actual review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants