-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] FreeRADIUS PostAuthView returns 500 error #467
Comments
@pandafy I want to work on this issue, can you assign this issue to me? |
@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄 I would recommend you to start by writing a failing test case before updating the serializer. I would also recommend you to join the OpenWISP development chat. |
can i start working on this? |
Yes @nick2432, go ahead! Don't forget to read my previous comments. |
Set the max_length attribute to be equal to 50 on the called_station_id field, so that it doesn't give a 500 error(400 error instead) every time it exceeds 50. Fixes openwisp#467
The QA check was failing earlier because the latest commit wasn't following the conventional commit guidelines, this commit fixes it. Ran both the openwisp-qa-format and openwisp-qa-check commands. Fixes openwisp#467
I want to work on this issue , can you pls assign me this ? |
Welcome @sumiran18! Create a PR first, then I'll assign it to you. |
Can I work on this issue? |
…uthSerializer openwisp#467 Updated the PostAuthSerializer to include a `max_length` attribute of 50 for the `called_station_id` field. This ensures that requests exceeding the character limit return an HTTP 400 error with an appropriate error message. Fixes openwisp#467
…station_id in PostAuthSerializer openwisp#467 Updated the PostAuthSerializer to include a `max_length` attribute of 50 for both the `called_station_id` and `calling_station_id` fields. This ensures that requests exceeding the character limit for either field return an HTTP 400 error with an appropriate error message. Added tests to validate the max_length constraint for both fields. Fixes openwisp#467
…adiusPostAuthSerializer openwisp#467 Removed the fields `called_station_id` and `calling_station_id` from the `RadiusPostAuthSerializer`. Increased the `max_length` of both fields to `253` and applied migrations. Fixes openwisp#467
Addressed migration check issue to causing qa-check fail Fixes openwisp#467
The FreeRADIUS PostAuthView (
/api/v1/freeradius/postauth/
) returns HTTP 500 error if the length ofcalled_station_id
field exceeds 50 characters.A possible fix could be to update the PostAuthSerializer and set
max_length
attribute on thecalled_station_id
field. This way, the view would return HTTP 400 with the error reason.The text was updated successfully, but these errors were encountered: