Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Test and Ensure App Support for Font Scaling up to 200% #5607

Open
theMr17 opened this issue Dec 19, 2024 · 1 comment
Open

[Feature Request]: Test and Ensure App Support for Font Scaling up to 200% #5607

theMr17 opened this issue Dec 19, 2024 · 1 comment
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@theMr17
Copy link
Collaborator

theMr17 commented Dec 19, 2024

Is your feature request related to a problem? Please describe.

The system, with SDK 34, now supports non-linear font scaling up to 200% for accessibility. The app requires thorough testing to ensure it functions correctly with larger font sizes. The app should display all UI elements correctly without any overlap or truncation.

Describe the solution you'd like

  1. Navigate to System Settings > Accessibility > Display size and text.
  2. Adjust the font size to 200% using the slider.
  3. Open the Oppia app and navigate through all screens.
  4. Observe and fix any UI issues such as overlap, overflow, or truncation of text and UI elements.

Here is a screenshot of the current Topic Screen with 200% font size:

Describe alternatives you've considered

No response

Additional context

This was discovered while analyzing the requirements in #5535.
@theMr17 theMr17 added enhancement End user-perceivable enhancements. triage needed labels Dec 19, 2024
@theMr17 theMr17 mentioned this issue Dec 19, 2024
Closed
@BenHenning
Copy link
Member

I think it's fine not to block the next release on this (especially since it's quite time sensitive), since I expect a lot of apps are going to break with this change in behavior.

@theMr17 theMr17 mentioned this issue Dec 27, 2024
Merged
6 tasks
BenHenning added a commit that referenced this issue Dec 29, 2024
@theMr17 @BenHenning
Fix #5535: Upgrade builds to target SDK 34 (#5604)
11aba3a 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
  
Fixes #5535

This PR updates all build and target SDKs for both Gradle and Bazel
builds to SDK 34 to comply with the latest Play Store requirements. The
key considerations for this upgrade include:

- **Font Scaling**: SDK 34 introduces support for font scaling up to
200% #5607.
- **`scaledDensity` Deprecation**: The scaledDensity property in the
DisplayMetrics class is now deprecated #5625.

Details about SDK 34 changes, potential issues, and mitigations can be
found in the #5535 issue thread.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Ben Henning <[email protected]>
@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanlip @BenHenning @adhiamboperes @theMr17