Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node-sass #2106

Closed
sweco-sedalh opened this issue Dec 11, 2024 · 0 comments · Fixed by #2107
Closed

Replace node-sass #2106

sweco-sedalh opened this issue Dec 11, 2024 · 0 comments · Fixed by #2107

Comments

@sweco-sedalh
Copy link
Contributor

Describe the bug
Origo currently uses node-sass to compile SASS to CSS. node-sass is no longer actively maintained, and breaks on newer versions of Node.

The recommended replacement is the dart-sass project, through the sass-embedded package. A part from some CLI-switches the replacement is fully compatible with the old node-sass, so no adjustments of the SASS code in Origo has to be done.

To Reproduce
Steps to reproduce the behavior:

  1. Install Node.js version 22
  2. Clone Origo (or remove node_modules)
  3. Run npm install

Expected behavior
Origo dependencies are built.

Instead, a long error message is produced (originating from node-gyp, a dependency of node-sass).

Screenshots
-

Desktop (please complete the following information):
-

Smartphone (please complete the following information):
-

Additional context
-

sweco-sedalh added a commit to sweco-sedalh/origo that referenced this issue Dec 11, 2024
node-sass is no longer actively developed, and breaks on newer versions of Node.js. sass-embedded is based on the dart-sass project and is almost a drop-in replacement.

Closes: origo-map#2106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant