Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Substitutions #1152

Closed
marcoag opened this issue Apr 29, 2024 · 4 comments
Closed

Using Substitutions #1152

marcoag opened this issue Apr 29, 2024 · 4 comments

Comments

@marcoag
Copy link
Member

marcoag commented Apr 29, 2024

Check the documentation for the 'Using Substitutions' page

Configuration

  • Chip set: AMD64
  • Build type: Debian
  • OS: Ubuntu Noble 24.04
  • DDS: FastDDS

Links

Process

Step 1 - I was able to follow the documentation.

Step 2 - The documentation seemed clear to me.

Step 3 - The documentation didn't have any obvious errors.

@knmcguire
Copy link

You can assign me to this. I'll be working on it with the provided Jazzy docker image

@knmcguire
Copy link

knmcguire commented May 10, 2024

  • Step 1 - I was able to follow the documentation.
  • Step 2 - The documentation seemed clear to me.
  • Step 3 - The documentation didn't have any obvious errors.

I was able to complete the tutorial, but I found this tutorial extremely difficult to follow and I had to re-read a couple of paragraphs multiple times...

Currently I've only done the launch.py variant and the yaml seems to be a bit shorter but I think the main problem is that multiple concepts, which are already advanced on their own, are being explained all in one go. I remember as well when I had to figure this concept out a little while ago, It was quite difficult for me to wrap my head around what is actually happening.

I'd like to finish up the rest of the launch tutorials first for the tutorial party, but for this one I'd like to look into rewriting this tutorial. This is quite an important feature of the launch functionality I think

@knmcguire
Copy link

There are no errors in this tutorial of what I could find, other than that the tutorial is hard to follow. I tried to do a rewrite but I think in general that the full launch series would need that and that is a much bigger endevor (see this issue: ros2/ros2_documentation#4453), but I see that as out of scope of this tutorial party.

For now, this tutorial does not contain errors so In my opinion you can close this issue.

@marcoag
Copy link
Member Author

marcoag commented May 16, 2024

Yup, sounds good. Thanks for the testing and the issue with all the info!

@marcoag marcoag closed this as completed May 16, 2024
@marcoag marcoag added the jazzy label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants