Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state_start/state_end to define_kernel() #35

Open
levisc8 opened this issue Aug 9, 2021 · 1 comment
Open

state_start/state_end to define_kernel() #35

levisc8 opened this issue Aug 9, 2021 · 1 comment

Comments

@levisc8
Copy link
Collaborator

levisc8 commented Aug 9, 2021

Mentioned by @Aariq in levisc8/ipmr_esa#3 - I think this would make a more intuitive UI. The rationale is that state_start/state_end are part of the symbolic kernel defintion anyway (i.e. they're the "z',z" in P(z',z) = ...), so they should be attached to define_kernel(), rather than a separate function.

This probably means dropping define_impl() and moving int_rule to define_domains(), or vice versa (depending on which function name feels more intuitive).

define_kernel(..., state_start = "z", state_end = "x") %>% 
define_domains(x = c(L_x, U_x, n_x), z = c(L_z, U_z, n_z))

@Aariq
Copy link
Contributor

Aariq commented Aug 9, 2021

I like define_impl(), for what it's worth. To me (someone relatively new to IPMs), it feels like defining the meshpoints is part of "implementation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants