Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-463] Enable full support for edge-to-edge navigation on Android #6602

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[IOAPPX-463] Enable full support for edge-to-edge navigation on Android #6602

wants to merge 6 commits into from
+61 −50

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 14, 2025 •
edited
Loading

Short description

This PR enables full support for edge-to-edge navigation on Android.

List of changes proposed in this pull request

  • Enable full support for edge-to-edge navigation by updating MainActivity.kt file
  • Fix splash screen ugly rectangles in both gesture and button navigation modes
  • Remove ugly white rectangle at the top of the BarcodeScanScreen
  • Remove ugly white rectangle at the top of the ServiceDetail screen
  • Update react-native-safe-area-context to the latest version

⚠️ Known issues

  • When gesture navigation mode is on, the inset padding won't be set correctly. This means:
    • Close button overlaps status bar when Help Centre is open
    • Toast notifications overlap the status bar
    • Bottom margins (with or without CTA) are too narrow
    • Bottom navigation bar margin is too narrow
  • There's still a white rectangle at the bottom of the IdentificationModal
  • When the button mode is enabled, the navigation bar will have an opaque black background instead of the light grey background it had before.

Preview

Splash screen

Before

Button mode Gesture mode
splash-screen-legacy splash-screen-edge-new

After

Button mode Gesture mode
Screenshot_20250114_123211 Screenshot_20250114_121630

Barcode Scan

Before After
barcode-screen-leg-edge barcode-screen-edge-new

Service Detail

Before After
service-detail-legacy-edge service-detail-edge-new

Related tech docs

How to test

  1. Run the app on Android
  2. Change navigation mode between button mode and gesture mode
  3. Navigate through the app to check that everything is working correctly

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-463

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter 💅 Visual tweaks labels Jan 14, 2025
@dmnplb dmnplb linked an issue Jan 14, 2025 that may be closed by this pull request
Enable Edge to edge - Android 15 #6599
Open
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.35%. Comparing base (f2659cf) to head (7521524).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6602      +/-   ##
==========================================
+ Coverage   49.30%   49.35%   +0.04%     
==========================================
  Files        1565     1565              
  Lines       32228    32228              
  Branches     7338     7334       -4     
==========================================
+ Hits        15891    15905      +14     
+ Misses      16299    16273      -26     
- Partials       38       50      +12
Files with missing lines Coverage Δ
ts/components/ui/AppHeader.tsx 100.00% <ø> (ø)
...code/components/BarcodeScanBaseScreenComponent.tsx 77.94% <ø> (-0.32%) ⬇️
ts/features/barcode/screens/BarcodeScanScreen.tsx 1.42% <ø> (ø)
ts/screens/modal/IdentificationModal.tsx 39.59% <100.00%> (+0.26%) ⬆️

... and 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2659cf...7521524. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew will be requested when the pull request is marked ready for review ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada will be requested when the pull request is marked ready for review gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 will be requested when the pull request is marked ready for review freddi301 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Design System New visual language and reduction of previous UI clutter 💅 Visual tweaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Edge to edge - Android 15
1 participant
@dmnplb