Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing py.typed marker #60

Open
RedKnite5 opened this issue Jun 16, 2024 · 2 comments
Open

Missing py.typed marker #60

RedKnite5 opened this issue Jun 16, 2024 · 2 comments

Comments

@RedKnite5
Copy link

All the code has type hints, but is missing a PEP 561 py.typed file, so type checkers like mypy ignore them when analyzing code that imports savepagenow. Just adding an empty file named py.typed should be enough.

@palewire
Copy link
Owner

Can you show me an example of an established package doing this?

@RedKnite5
Copy link
Author

PyTest has a couple in these directories
https://github.com/pytest-dev/pytest/tree/main/src/_pytest
https://github.com/pytest-dev/pytest/tree/main/src/pytest

I believe its more common for large packages to use stubs, but inline type annotations with py.typed work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants