-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: value_counts to consistently maintain order of input #59745
Merged
mroeschke
merged 7 commits into
pandas-dev:main
from
rhshadrach:groupby_value_counts_sort
Oct 6, 2024
Merged
API: value_counts to consistently maintain order of input #59745
mroeschke
merged 7 commits into
pandas-dev:main
from
rhshadrach:groupby_value_counts_sort
Oct 6, 2024
+157
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Algos
Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
API - Consistency
Internal Consistency of API/Behavior
labels
Sep 7, 2024
mroeschke
reviewed
Sep 9, 2024
mroeschke
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this change. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just checked the whatsnew note)
Thanks @rhshadrach |
This broke the following case:
with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Algos
Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
API - Consistency
Internal Consistency of API/Behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Context is here: #59307 (comment)