BUG: Ensure to_datetime raises errors for out-of-bounds scalar inputs #60744
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosiew
changed the title
kosiew
commented
Jan 21, 2025
pandas/core/tools/datetimes.py
Outdated
| @@ -479,11 +479,20 @@ def _array_strptime_with_fallback( | |||
| return Index(result, dtype=result.dtype, name=name) | |||
|
|
|||
|
|
|||
| def _to_datetime_with_unit(arg, unit, name, utc: bool, errors: str) -> Index: | |||
| def _to_datetime_with_unit(arg, unit, name, utc: bool, errors: str) -> DatetimeIndex: | |||
There was a problem hiding this comment.
Making the annotation -> DatetimeIndex reflects that reality more precisely and helps both developers and tooling (like mypy) be certain of the return type.
There was a problem hiding this comment.
If errors=="ignore" we would get an Index[object] back so this is correct
There was a problem hiding this comment.
Good point. Thanks for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.