From f02f06306765587d20d7b4a5cc5acfafe6337460 Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Wed, 24 Jan 2024 11:26:12 +0200 Subject: [PATCH 1/3] rpc-v2/tx: Rename `transaction` to `transactionWatch` Signed-off-by: Alexandru Vasile --- substrate/client/rpc-spec-v2/src/transaction/api.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/substrate/client/rpc-spec-v2/src/transaction/api.rs b/substrate/client/rpc-spec-v2/src/transaction/api.rs index 3eb6cb204f24..53c83b662a35 100644 --- a/substrate/client/rpc-spec-v2/src/transaction/api.rs +++ b/substrate/client/rpc-spec-v2/src/transaction/api.rs @@ -29,8 +29,8 @@ pub trait TransactionApi { /// See [`TransactionEvent`](crate::transaction::event::TransactionEvent) for details on /// transaction life cycle. #[subscription( - name = "transaction_unstable_submitAndWatch" => "transaction_unstable_watchEvent", - unsubscribe = "transaction_unstable_unwatch", + name = "transactionWatch_unstable_submitAndWatch" => "transactionWatch_unstable_watchEvent", + unsubscribe = "transactionWatch_unstable_unwatch", item = TransactionEvent, )] fn submit_and_watch(&self, bytes: Bytes); From d5ee5b5f9eddaade3e19cfb919008657f785f6a3 Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Wed, 24 Jan 2024 11:46:16 +0200 Subject: [PATCH 2/3] prdoc: Add prdoc Signed-off-by: Alexandru Vasile --- prdoc/pr_3040.prdoc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 prdoc/pr_3040.prdoc diff --git a/prdoc/pr_3040.prdoc b/prdoc/pr_3040.prdoc new file mode 100644 index 000000000000..703dfdada5fc --- /dev/null +++ b/prdoc/pr_3040.prdoc @@ -0,0 +1,14 @@ +# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 +# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json + +title: rpc-v2/tx: Rename transaction to transactionWatch + +doc: + - audience: Node Dev + description: | + Renamed `transaction_unstable_submitAndWatch` to `transactionWatch_unstable_submitAndWatch`, + `transaction_unstable_watchEvent` to `transactionWatch_unstable_watchEvent` and + `transaction_unstable_unwatch` to `transactionWatch_unstable_unwatch`. + +crates: +- name: sc-rpc-spec-v2 From a0420a710446f9cd8255c2d01d8a6111e2f75139 Mon Sep 17 00:00:00 2001 From: Alexandru Vasile Date: Wed, 24 Jan 2024 11:51:58 +0200 Subject: [PATCH 3/3] prodoc: Names must have no `:` entries Signed-off-by: Alexandru Vasile --- prdoc/pr_3040.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_3040.prdoc b/prdoc/pr_3040.prdoc index 703dfdada5fc..01f3d731c69c 100644 --- a/prdoc/pr_3040.prdoc +++ b/prdoc/pr_3040.prdoc @@ -1,7 +1,7 @@ # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json -title: rpc-v2/tx: Rename transaction to transactionWatch +title: Rename transaction to transactionWatch doc: - audience: Node Dev