Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-DOOM ELF binaries from test-data #209

Open
koute opened this issue Nov 1, 2024 · 3 comments · May be fixed by #240
Open

Remove non-DOOM ELF binaries from test-data #209

koute opened this issue Nov 1, 2024 · 3 comments · May be fixed by #240
Labels
D-easy An easy issue that might be good for someone new P-low Low priority

Comments

@koute
Copy link
Collaborator

koute commented Nov 1, 2024

Since we're using an upstream toolchain now we don't have to keep bench-pinky and test-blob ELF binaries in test-data anymore; we should instead trigger their generation as needed from the tests themselves.
@koute koute added P-low Low priority D-easy An easy issue that might be good for someone new labels Nov 1, 2024
@jarkkojs
Copy link
Collaborator

Which binaries test-data file map exactly (32/64 versions)?

@jarkkojs jarkkojs mentioned this issue Nov 22, 2024
Closed
@jarkkojs
Copy link
Collaborator

@koute can we migrate CargoCommand* to polkavm? Then the script would not be absolutely necessary.

@koute
Copy link
Collaborator Author

koute commented Nov 23, 2024

How to do this: create a new crate (polkavm-test-data), build the test data from its build.rs (by shelling out to cargo, and then calling into the linker crate), add the new crate as a dev dependency to polkavm crate to use in tests, delete the ELF blobs from test-data.

@jarkkojs jarkkojs linked a pull request Dec 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy An easy issue that might be good for someone new P-low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

polkavm-test-data paritytech/polkavm
2 participants
@jarkkojs @koute