Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Push adapter not loading on some versions of Node 22 #9524

Merged
merged 14 commits into from
Jan 11, 2025
Merged

fix: Push adapter not loading on some versions of Node 22 #9524

merged 14 commits into from
Jan 11, 2025
+2 −14

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 10, 2025

Pull Request

Issue

The push adapter type stops the server from starting

Closes: #9517

Approach

Uses the .default export for the push adapter

@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: invalid push adapter type fix: Invalid push adapter type Jan 10, 2025
@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

@dblythy dblythy force-pushed the fix-adapters branch 2 times, most recently from 6aea65c to 5793d09 Compare January 10, 2025 00:40
@dblythy dblythy closed this Jan 10, 2025
@dblythy dblythy reopened this Jan 10, 2025
@dblythy
Copy link
Member Author

dblythy commented Jan 10, 2025

It seems that the Node 22 testing env was not added, even though the project is listed to support node 22

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (4e151cd) to head (ebe9016).
Report is 3 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #9524      +/-   ##
==========================================
+ Coverage   84.33%   93.51%   +9.18%     
==========================================
  Files         186      186              
  Lines       14810    14804       -6     
==========================================
+ Hits        12490    13844    +1354     
+ Misses       2320      960    -1360

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblythy dblythy requested a review from a team January 10, 2025 01:25
@dblythy dblythy changed the title fix: Invalid push adapter type fix: add Node 22 to testing matrix Jan 10, 2025
@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add Node 22 to testing matrix fix: Add Node 22 to testing matrix Jan 10, 2025
mtrezza
mtrezza reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, seems like the fix is only the change in src/Adapters/AdapterLoader.js, right? If so, could you please revert all other changes and submit a PR also for the release-7.x.x branch? And could you please rephrase the PR title, so indicate what the issue is for the changelog entry?

@dblythy
Copy link
Member Author

dblythy commented Jan 10, 2025

Sure - I still think it's worth adding the tests for Node 22 considering it's listed as supported

@dblythy dblythy changed the title fix: Add Node 22 to testing matrix fix: Push adapter not loading on Node 22 Jan 10, 2025
@mtrezza
Copy link
Member

mtrezza commented Jan 10, 2025 •
edited
Loading

I understand the bug occurs from a specific Node 22 version onwards; the Node 22 bump occurs in #9521, which is actually a broader change.

@mtrezza
Copy link
Member

mtrezza commented Jan 10, 2025 •
edited
Loading

Could you lower this to Node 22.12.0, which is also the Node version in #9521? So we don't have to downgrade again to meet our engines.node version. The bug occurs in that version as well.

mtrezza
mtrezza reviewed Jan 10, 2025
View reviewed changes
spec/CLI.spec.js Outdated Show resolved Hide resolved
@pocketcolin pocketcolin mentioned this pull request Jan 10, 2025
Open
@dblythy dblythy requested a review from a team January 11, 2025 07:54
mtrezza
mtrezza approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: Push adapter not loading on Node 22 fix: Push adapter not loading on some versions of Node 22 Jan 11, 2025
@mtrezza mtrezza mentioned this pull request Jan 11, 2025
Merged
@mtrezza mtrezza merged commit ff7f671 into parse-community:alpha Jan 11, 2025
25 of 30 checks passed
parseplatformorg pushed a commit that referenced this pull request Jan 11, 2025
@semantic-release-bot
chore(release): 8.0.0-alpha.2 [skip ci]
fbf78f0 
# [8.0.0-alpha.2](8.0.0-alpha.1...8.0.0-alpha.2) (2025-01-11)

### Bug Fixes

* Push adapter not loading on some versions of Node 22 ([#9524](#9524)) ([ff7f671](ff7f671))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
3 participants
@dblythy @mtrezza @parseplatformorg