Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1:1]: pf-backdrop #2541

Open
ArathyKumar opened this issue Jul 7, 2023 · 2 comments
Open

[1:1]: pf-backdrop #2541

ArathyKumar opened this issue Jul 7, 2023 · 2 comments
Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language new component request priority: low Severity level: 3 red hack day Good issue for Red Hack Day

Comments

@ArathyKumar
Copy link
Collaborator

Component name: pf-backdrop

A backdrop is used to screen the main content of a page when a modal overlay is opened. It prevents the user from doing other work on the page until the modal is dismissed.
Reference: https://www.patternfly.org/v4/components/backdrop

Screenshot 2023-07-07 at 1 19 44 PM

Design specification

The design specifications should match with https://www.patternfly.org/v4/components/backdrop/design-guidelines.

Accessibility

The component should implement all the accessibility features as https://www.patternfly.org/v4/components/backdrop/accessibility.
@ArathyKumar ArathyKumar added design system Updates or issues to align components to the Red Hat Design System. new component request priority: low Severity level: 3 labels Jul 7, 2023
@bennypowers
Copy link
Member

we may choose not to implement this, if this is simply an implementation detail of modal

@bennypowers bennypowers added the 1:1 Aligning components with PatternFly v4 label Jul 31, 2023
@zeroedin
Copy link
Collaborator

we may choose not to implement this, if this is simply an implementation detail of modal

There is an implementation of the backdrop that does have a spinner

http://v4-archive.patternfly.org/v4/components/backdrop/react/with-spinner/

I wonder if that qualifies it enough as a stand alone component. I could see that being used outside a modal.

@bennypowers bennypowers added the good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language label Jun 10, 2024
@markcaron markcaron added the red hack day Good issue for Red Hack Day label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. good 1st issue Good for newcomers to the project; requires at least an introductory knowledge of the language new component request priority: low Severity level: 3 red hack day Good issue for Red Hack Day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeroedin @bennypowers @markcaron @ArathyKumar