Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patternfly QuickStart CSS is skewing icon #147

Closed
abhinandan13jan opened this issue Mar 23, 2022 · 1 comment
Closed

Patternfly QuickStart CSS is skewing icon #147

abhinandan13jan opened this issue Mar 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@abhinandan13jan
Copy link
Contributor

abhinandan13jan commented Mar 23, 2022

This piece of CSS is causing this issue -> Catalog tile Icon is skewed (https://bugzilla.redhat.com/show_bug.cgi?id=2029977)

Filename: quickstarts.min.css
.catalog-tile-pf-icon { //from patternfly quickStarts
    font-size: 40px;
    height: 40px;
    max-width: 60px;
    min-width: 40px;
}

DevCatalog-BadLogo

instead of

DevCatalogLogoLooksGood-FromChristian

img is constrained on both width and height which should not happen

@jessiehuff jessiehuff added this to the Prioritized Backlog milestone Mar 29, 2022
@CooperRedhat CooperRedhat added the bug Something isn't working label Jul 25, 2022
@CooperRedhat CooperRedhat self-assigned this Jul 25, 2022
@jschuler
Copy link
Collaborator

jschuler commented Sep 7, 2022

This CSS is coming from the patternfly-react repo. I've reopened your issue here
patternfly/react-catalog-view#19

One thing you can do if you don't want to load the catalog css twice, you can import just the base CSS from quickstarts this way:

import '@patternfly/quickstarts/dist/quickstarts-base.css'

The normal @patternfly/quickstarts/dist/quickstarts.css file is a combination of the above plus dist/quickstarts-vendor.css which contains styles from:

@import '@patternfly/react-catalog-view-extension/dist/sass/react-catalog-view-extension.scss';
@import '@patternfly/patternfly/components/ClipboardCopy/clipboard-copy.scss';
@import '@patternfly/patternfly/components/CodeBlock/code-block.scss';

@jschuler jschuler closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants