Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card- consider refactoring markup for clickable cards #10188

Closed
jessiehuff opened this issue Mar 22, 2024 · 3 comments · Fixed by #10859
Closed

Card- consider refactoring markup for clickable cards #10188

jessiehuff opened this issue Mar 22, 2024 · 3 comments · Fixed by #10859
Assignees
Labels

Comments

@jessiehuff
Copy link
Contributor

Describe the problem
When tabbing through the clickable cards, it almost appears as if the second card doesn't receive focus. It looks like the clickable card is performing the action on focus AND on click. It seems like it's clicking the link on focus which is why focus shifts off it so fast. This would be worth some investigation.

How do you reproduce the problem?
Go to clickable card example, use your keyboard to tab through and try to perform all actions.

Expected behavior
To be able to use Tab to navigate cards and enter to click them.

@thatblindgeye
Copy link
Contributor

Jessie and I briefly discussed this during a meet, and this may be due to clickable cards currently utilizing visually hidden radio inputs to create the "fully clickable card" effect. Native radio inputs allow tabbing between inputs when no option is selected, but require arrow keys to traverse/select another radio once a selection has been made. If you Tab to the first clickable card in the example linked above, pressing Down Arrow should navigate to (then trigger) the second card.

@thatblindgeye thatblindgeye changed the title Bug - Card- clickable card keyboard navigation not working properly Spike - Card- consider refactoring markup/API for selectable/clickable cards Apr 10, 2024
@thatblindgeye thatblindgeye removed the bug label Apr 10, 2024
@thatblindgeye thatblindgeye self-assigned this Apr 10, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Not started in PatternFly Issues Apr 10, 2024
@thatblindgeye
Copy link
Contributor

Updating this issue to be more of a spike regarding refactoring the markup and API of the selectable/card implementations. This would also require updates made in Core.

@thatblindgeye thatblindgeye moved this from Not started to Backlog in PatternFly Issues Apr 11, 2024
@kmcfaul kmcfaul moved this from Backlog to Not started in PatternFly Issues May 9, 2024
@thatblindgeye thatblindgeye changed the title Spike - Card- consider refactoring markup/API for selectable/clickable cards Card- consider refactoring markup for clickable cards Aug 14, 2024
@thatblindgeye thatblindgeye linked a pull request Aug 15, 2024 that will close this issue
@thatblindgeye
Copy link
Contributor

Closed by 10859

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants