Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuToggle - icons should be passed via icon prop #10841

Closed
kmcfaul opened this issue Aug 7, 2024 · 0 comments · Fixed by #11005
Closed

MenuToggle - icons should be passed via icon prop #10841

kmcfaul opened this issue Aug 7, 2024 · 0 comments · Fixed by #11005
Assignees
@evwilkin
Milestone
2024.Q4

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 7, 2024

Our examples/demos should be reviewed to make sure we are passing icons in menu toggles in through the icon prop so they are wrapped in the correct icon wrapper.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 7, 2024
@tlabaj tlabaj added the Post v6 label Aug 27, 2024
@kmcfaul kmcfaul added this to the Penta final release milestone Aug 27, 2024
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues Aug 27, 2024
@kmcfaul kmcfaul removed the Post v6 label Aug 27, 2024
@evwilkin evwilkin mentioned this issue Sep 15, 2024
Merged
@evwilkin evwilkin self-assigned this Sep 15, 2024
@evwilkin evwilkin moved this from Not started to PR Review in PatternFly Issues Sep 26, 2024
@kmcfaul kmcfaul modified the milestones: Penta final release, 2024.Q3 Sep 26, 2024
@kmcfaul kmcfaul removed the Tech debt label Oct 25, 2024
@tlabaj tlabaj modified the milestones: 2024.Q3, 2024.Q4 Nov 5, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evwilkin evwilkin

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2024.Q4
Development

Successfully merging a pull request may close this issue.

chore(docs): update menutoggle examples icon prop evwilkin/patternfly-react
3 participants
@evwilkin @tlabaj @kmcfaul