Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextArea - add support for disabling resize #11130

Closed
jenny-s51 opened this issue Oct 22, 2024 · 1 comment · Fixed by #11383
Closed

TextArea - add support for disabling resize #11130

jenny-s51 opened this issue Oct 22, 2024 · 1 comment · Fixed by #11383
Assignees
Milestone

Comments

@jenny-s51
Copy link
Contributor

Is this a new component or an extension of an existing one?
What is the existing component, if any?
Existing, TextArea

Describe the feature
A clear and concise description of the new feature. What is the expected behavior?

TextArea has resize enabled by default via resizeOrientation which is set to 'both' in defaultProps: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/TextArea/TextArea.tsx#L55

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

In Kubeflow, we would like to disable the resize to match how MUI themes their text fields. Since PF has resize enabled by default, this applies the .pf-m-resize-both modifier to the pf-v6-c-form-control component which requires a CSS override. Therefore in this case we wouldn't have this modifier applied to pf-v6-c-form-control.

Current:
Image

Expected:
Image

Any other information?
cc @mcoker @srambach opening this issue per our discussion today on applying PF breaking change best practices in Kubeflow

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 22, 2024
@kmcfaul kmcfaul removed the Feature label Oct 25, 2024
@tlabaj tlabaj moved this from Needs triage to Ready to assign in PatternFly Issues Nov 5, 2024
@tlabaj tlabaj added this to the 2024.Q4 milestone Nov 5, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Nov 21, 2024

Maybe add a resize-off variant to resizeOrientation prop. This would remove any classes for resizing.

@tlabaj tlabaj modified the milestones: 2024.Q4, 2025.Q1 Nov 21, 2024
@tlabaj tlabaj self-assigned this Jan 7, 2025
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Jan 7, 2025
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Jan 7, 2025
@tlabaj tlabaj moved this from In Progress to PR Review in PatternFly Issues Jan 7, 2025
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants