Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal - create variation using dialog element #11422

Open
srambach opened this issue Jan 14, 2025 · 0 comments
Open

Modal - create variation using dialog element #11422

srambach opened this issue Jan 14, 2025 · 0 comments
Labels

Comments

@srambach
Copy link
Member

Is this a new component or an extension of an existing one?
The Modal creates a ModalBox, which will have a variation in Core built using the <dialog> element.

Describe the feature
<dialog> provides functionality built into browsers that handles placing the modal on the top layer, handling keyboard focus, and providing a ::backdrop pseudoelement. Users should be able to opt in to this variant, which then probably does not need the separate Backdrop component, may not need to be placed in the DOM where it is now, and focus will be handled by the browser. A11y should be reviewed given that the dialog implicitly provides appropriate aria labeling.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

This issue is dependent on completion in core in patternfly/patternfly#7296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant