-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Hint): Consume Penta tokens #9807
Comments
Doesn't seem like any updates would be needed in React. Am noticing, between the React component and what's on the v6 staging for Core, there are some slight differences:
Will mention during one of the Penta happy hours this week for confirmation about the font family |
@mcoker @andrew-ronaldson can you please verify that the Hint component looks good on staging so we can close this issue. |
LGTM! FYI I just:
Visually the spacing between core and react looks a little different, but I believe that is just due to the presence and size of the hint actions - having an action in the layout causes the spacing to change a bit. I created an issue for that patternfly/patternfly#6116 |
this looks good to me! The styling of the menu icon seems off, but that's probably because menus haven't been fully penta-fied in core yet. thanks! |
Closing per comments above |
Follow up to core: patternfly/patternfly#5997
The text was updated successfully, but these errors were encountered: