Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hint): Consume Penta tokens #9807

Closed
Tracked by #9680
tlabaj opened this issue Nov 9, 2023 · 5 comments
Closed
Tracked by #9680

(Hint): Consume Penta tokens #9807

tlabaj opened this issue Nov 9, 2023 · 5 comments
Assignees
Milestone

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Nov 9, 2023

Follow up to core: patternfly/patternfly#5997

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 9, 2023
@tlabaj tlabaj added the Penta label Nov 9, 2023
@tlabaj tlabaj changed the title (Hint): Add Penta tokens (Hint): Consume Penta tokens Nov 9, 2023
@tlabaj tlabaj added this to the 2023.Q3 milestone Nov 9, 2023
@tlabaj tlabaj added the PF6 label Nov 9, 2023
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Nov 9, 2023
@tlabaj tlabaj moved this from Backlog to On deck in PatternFly Issues Nov 9, 2023
@thatblindgeye thatblindgeye moved this from On deck to Not started in PatternFly Issues Nov 17, 2023
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Nov 28, 2023
@thatblindgeye
Copy link
Contributor

thatblindgeye commented Nov 28, 2023

Doesn't seem like any updates would be needed in React. Am noticing, between the React component and what's on the v6 staging for Core, there are some slight differences:

  • slightly more space around the hint border and content in React (possibly due to the icon in React being svg) EDIT: Confirmed that this may be due to core using the deprecated Dropdown in the example
  • the font in React doesn't match Core for the hint title and body (redhatdisplayvf / redhattextvf in Core, redhatdisplay /. redhattext in React) EDIT: Confirmed that this is no longer an issue with thelatest Core alphas pulled in

Will mention during one of the Penta happy hours this week for confirmation about the font family

@tlabaj
Copy link
Contributor Author

tlabaj commented Dec 6, 2023

@mcoker @andrew-ronaldson can you please verify that the Hint component looks good on staging so we can close this issue.

@mcoker
Copy link
Contributor

mcoker commented Dec 6, 2023

LGTM! FYI I just:

Visually the spacing between core and react looks a little different, but I believe that is just due to the presence and size of the hint actions - having an action in the layout causes the spacing to change a bit. I created an issue for that patternfly/patternfly#6116

Screenshot 2023-12-06 at 2 20 37 PM

@lboehling
Copy link
Collaborator

this looks good to me! The styling of the menu icon seems off, but that's probably because menus haven't been fully penta-fied in core yet. thanks!

@thatblindgeye
Copy link
Contributor

Closing per comments above

@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants