Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Alert): Consume Penta tokens #9810

Closed
Tracked by #9680
tlabaj opened this issue Nov 9, 2023 · 4 comments
Closed
Tracked by #9680

(Alert): Consume Penta tokens #9810

tlabaj opened this issue Nov 9, 2023 · 4 comments
Assignees
@tlabaj
Milestone
2023.Q3

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Nov 9, 2023 •
edited
Loading

Follow up to core patternfly/patternfly#5996
@tlabaj tlabaj mentioned this issue Nov 9, 2023
Closed
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 9, 2023
@tlabaj tlabaj added the Penta label Nov 9, 2023
@tlabaj tlabaj added this to the 2023.Q3 milestone Nov 9, 2023
@tlabaj tlabaj added the PF6 label Nov 9, 2023
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Nov 9, 2023
@tlabaj tlabaj moved this from Backlog to On deck in PatternFly Issues Nov 9, 2023
@tlabaj
Copy link
Contributor Author

tlabaj commented Dec 5, 2023

@andrew-ronaldson @srambach It looks like nothing needs to be done in react for this one. Can you please verify that staging looks good to you so we can close this issue.

@wise-king-sullyman wise-king-sullyman moved this from On deck to In Progress in PatternFly Issues Dec 5, 2023
@srambach
Copy link
Member

srambach commented Dec 5, 2023

Just checking - @andrew-ronaldson in core, we don't show a "default" alert without any status styling, and it's not in Figma. Is this use here ok? https://patternfly-react-v6.surge.sh/components/alert/react-demos/alert-group-toast-with-notification-drawer/

@andrew-ronaldson
Copy link
Collaborator

andrew-ronaldson commented Dec 5, 2023 •
edited
Loading

We don't have a plain alert except for the overflow version which I see in the demo already.
image

@andrew-ronaldson
Copy link
Collaborator

This is good to go!

@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlabaj tlabaj

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q3
Development

No branches or pull requests
3 participants
@srambach @andrew-ronaldson @tlabaj