Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup - DataListAction - id, aria-label and aria-labelledby are not currently in use but are required #9823

Open
kmcfaul opened this issue Nov 15, 2023 · 2 comments
Labels
Breaking change 💥 this change requires a major release and has API changes. Pinned

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Nov 15, 2023

id can probably remain (and if so should be made non-required) but aria-label and aria-labelledby should be removed because they don't usually exist on a div without a role. These props were a holdover from when we were using a Button internally opposed to children.

@kmcfaul kmcfaul added the bug label Nov 15, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 15, 2023
@kmcfaul kmcfaul added Breaking change 💥 this change requires a major release and has API changes. needs triage and removed Breaking change 💥 this change requires a major release and has API changes. labels Nov 15, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Nov 21, 2023
Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2024
@tlabaj tlabaj added Pinned and removed wontfix labels Feb 8, 2024
@tlabaj tlabaj added the Breaking change 💥 this change requires a major release and has API changes. label Apr 10, 2024
@dgdavid
Copy link
Contributor

dgdavid commented Aug 10, 2024

but aria-label and aria-labelledby should be removed because they don't usually exist on a div without a role

In addition, if they remain only one of them should be required, right?

@kmcfaul kmcfaul removed the bug label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change 💥 this change requires a major release and has API changes. Pinned
Projects
Status: Backlog
Development

No branches or pull requests

4 participants