From 303155724c8901c899e90064a43d1f61378b54d7 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 13 Dec 2023 08:49:04 -0500 Subject: [PATCH 1/3] fix(Chip): prevented duplicate ID being applied --- packages/react-core/src/components/Chip/Chip.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-core/src/components/Chip/Chip.tsx b/packages/react-core/src/components/Chip/Chip.tsx index 12ab24e665c..fd7a17cbc5d 100644 --- a/packages/react-core/src/components/Chip/Chip.tsx +++ b/packages/react-core/src/components/Chip/Chip.tsx @@ -149,6 +149,8 @@ class Chip extends React.Component { isOverflowChip, // eslint-disable-next-line @typescript-eslint/no-unused-vars tooltipPosition, + // eslint-disable-next-line @typescript-eslint/no-unused-vars + id: idProp, component, ouiaId, textMaxWidth, From 8ae0180c404475d4add0560d447c598f4d692c4d Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 13 Dec 2023 08:50:26 -0500 Subject: [PATCH 2/3] Updated snapshot --- .../components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap b/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap index 2216d2e45cc..88f68f2975d 100644 --- a/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap +++ b/packages/react-core/src/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap @@ -7,7 +7,6 @@ exports[`Matches snapshot 1`] = ` data-ouia-component-id="snapshot-test" data-ouia-component-type="PF5/Chip" data-ouia-safe="true" - id="snapshot-test" > Date: Wed, 13 Dec 2023 09:21:18 -0500 Subject: [PATCH 3/3] Updated integration test selector --- packages/react-integration/cypress/integration/chip.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-integration/cypress/integration/chip.spec.ts b/packages/react-integration/cypress/integration/chip.spec.ts index 280614d39b9..7cbf5cdd4ad 100644 --- a/packages/react-integration/cypress/integration/chip.spec.ts +++ b/packages/react-integration/cypress/integration/chip.spec.ts @@ -4,7 +4,7 @@ describe('Chip Group Demo Test', () => { }); it('Verify tooltipPosition is passed to Tooltip', () => { - cy.get('#longName-chip').focus(); + cy.get('.pf-v5-c-chip').focus(); cy.get('.pf-v5-c-tooltip').should('have.class', 'pf-m-bottom'); }); });