Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card - update markup/API has changed #736

Closed
thatblindgeye opened this issue Aug 13, 2024 · 0 comments · Fixed by #738
Closed

Card - update markup/API has changed #736

thatblindgeye opened this issue Aug 13, 2024 · 0 comments · Fixed by #738
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Aug 13, 2024

Follow up to breaking change PR patternfly/patternfly-react#10859

Based on changes made locally as followup to card changes in Core, the markup for clickable cards is expected to change. Additionally, there will now be a console error if a clickable only or selectable only card does not have a proper accessible name (technically a change as it makes 1 of the aria props required, but this should have been how it was in the first place)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant