Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redis dependency? #419

Open
spacebear21 opened this issue Nov 28, 2024 · 3 comments
Open

Replace redis dependency? #419

spacebear21 opened this issue Nov 28, 2024 · 3 comments

Comments

@spacebear21
Copy link
Collaborator

Redis moved to closed-source and the rust crate is being disputed. redis-rs/redis-rs#1419

@DanGould
Copy link
Contributor

valkey is the obvious candidate that comes to mind.

@0xBEEFCAF3
Copy link
Collaborator

I would put my vote in for sled. Its simple to work with and fast.

@DanGould
Copy link
Contributor

Unfortunately sled hasn't been maintained for 2 years which I reasoned was OK for payjoin-cli since it's a bit of a demo tool, but probably not ok for the aspirationally production-hardened payjoin-directory.

Redb is an alternative I hear come up a lot for sled, but no modern version of it complies with our MSRV. Now, I'd be ok bumping MSRV just for payjoin-directory but NOT for the payjoin crate. Not sure how much trouble multiple crates with different MSRV would be for our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants