Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender: allow for multiple payouts #437

Open
0xBEEFCAF3 opened this issue Dec 11, 2024 · 2 comments
Open

sender: allow for multiple payouts #437

0xBEEFCAF3 opened this issue Dec 11, 2024 · 2 comments
Assignees
Milestone

Comments

@0xBEEFCAF3
Copy link
Collaborator

original TODO comment:

// TODO support optional batched payout scripts. This would require a change to

Allow a sender to be created that pays out to multiple destination addresses. We should replace check_single_payee with check_for_all_payouts and unit test it

@DanGould
Copy link
Contributor

DanGould commented Jan 3, 2025

This kind of multiparty API change needs to be experimented with before payjoin-1.0 so we know that our stable API can accommodate it. It would be crappy to stabilize the API and realize multiparty required a complete re-implementation with a different API.

@0xBEEFCAF3 0xBEEFCAF3 self-assigned this Jan 5, 2025
@0xBEEFCAF3
Copy link
Collaborator Author

Agreed. This is tangentially related to #434 however it really could be its own effort as well. The interface question is really how do we communicate more than one payee address in a BIP-21. IIRC the spec doesnt account for more than one payee so we could utilize some custom query params but then support and intergration becomes a burden. BIP-321 is a BIP to revisit BIP-21 this could be an interesting place to advocate for multi payee support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants