Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo-minimal.lock and Cargo-recent.lock have the same contents. Is this right? #454

Open
3 tasks
DanGould opened this issue Jan 2, 2025 · 2 comments
Open
3 tasks
Labels
question Further information is requested

Comments

@DanGould
Copy link
Contributor

DanGould commented Jan 2, 2025

sha256sum Cargo-minimal.lock Cargo-recent.lock
cfc03189fb6e75ba99b0b74b0abf46e942c96c99ef2266538e99d7a7ec746ffb Cargo-minimal.lock
cfc03189fb6e75ba99b0b74b0abf46e942c96c99ef2266538e99d7a7ec746ffb Cargo-recent.lock

I have been running ./contrib/update-lock-files.sh once to get CI to pass thinking it automatically handled locking MSRV dependencies. But I don't see that they're actually different.

  • Check the commit log to see where they unified, if ever
  • If not, describe how our CI passes MSRV tests without locking
  • Fix the script to accommodate MSRV dependency requirements

s/o @nothingmuch for discovering this

@DanGould DanGould added the question Further information is requested label Jan 2, 2025
@nothingmuch
Copy link
Collaborator

nothingmuch commented Jan 2, 2025

is the purpose of the minimal lockfile just to work with msrv or are there other reasons?

is the purpose of recent to always be as up to date as possible?

somewhat relatedly, cargo audit is unhappy with some of our deps, and machete suggests some dependencies for removal. i'm wrapping up the flake stuff where this came up, and will open separate issues & draft PRs for these, but resolving them depends on the answer to this question IMO

@nothingmuch
Copy link
Collaborator

is the purpose of recent to always be as up to date as possible?

and if so, then this probably merits a daily or weekly automated update PR in a github workflow, assuming we trust the end to end tests enough that they will reliably discover if anything breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

2 participants