Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receive::v2::SessionContext holds ohttp_relay when that should be a parameter to extract_req #465

Closed
DanGould opened this issue Jan 6, 2025 · 0 comments · Fixed by #470
Closed

receive::v2::SessionContext holds ohttp_relay when that should be a parameter to extract_req #465

DanGould opened this issue Jan 6, 2025 · 0 comments · Fixed by #470
Labels
api

Comments

@DanGould
Copy link
Contributor

DanGould commented Jan 6, 2025

The SessionContext is not tied to a particular OHTTP Relay and may even benefit by distributing polled requests across a few different relays.
@DanGould DanGould added the api label Jan 6, 2025
@DanGould DanGould mentioned this issue Jan 8, 2025
Merged
DanGould added a commit that referenced this issue Jan 13, 2025
@DanGould
Remove ohttp_relay from SessionContext (#470)
6f9e6b3 
The context may use multiple OHTTP Relays, so pass it in the extract
method instead.

fix #465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
Payjoin Roadmap 📝
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ohttp_relay from SessionContext DanGould/rust-payjoin
1 participant
@DanGould