Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test OHTTP relay in integration tests #476

Open
spacebear21 opened this issue Jan 13, 2025 · 0 comments
Open

Properly test OHTTP relay in integration tests #476

spacebear21 opened this issue Jan 13, 2025 · 0 comments

Comments

@spacebear21
Copy link
Collaborator

Our integration tests currently fail to relay messages through the OHTTP
Relay to the Directory, so they need to pass messages directly to the
directory. The reason they're failing otherwise is because the OHTTP
Relay only forwards requests using rustls with_webpki_roots, the
tests' directory Urls use HTTPS, and the webpki_roots do not contain
or allow self-signed certificates. I.e. we have not equivalent
_danger-local-https feature available in ohttp_relay and the request
isn't downgraded to plain HTTP, so it fails to relay.

We may consider having extract_req functions downgrade OHTTP requests
to directory targets to HTTP, because they are protected with e2ee as
part of OHTTP outside of HTTPS.

Originally posted by @DanGould in #470 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant