Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging metrics #29

Open
orangejulius opened this issue Oct 3, 2017 · 2 comments
Open

Add support for logging metrics #29

orangejulius opened this issue Oct 3, 2017 · 2 comments

Comments

@orangejulius
Copy link
Member

Right now Pelias logger can only log text. If a user of Pelias wants to log metrics somehow, they have to aggregate those log files and define metrics based on patterns within those log files.

This isn't ideal because the pattern matching is often very tough to get right and debug, it requires more services being run as part of a Pelias setup, and there is no indication in the Pelias code that a seemingly unimportant log line might actually be used to drive a critical metric.

First class support for logging metrics directly, through a configurable backend, should be added. statsd is an obvious backend to support. AWS CloudWatch Metrics might be another one worth supporting.

@orangejulius
Copy link
Member Author

orangejulius commented Sep 1, 2018

I am considering closing this. After #30, we can now send the logs as JSON, which is quite flexible, and doesn't prescribe any particular metrics/observability platform like statsd, prometheus, etc.

If anyone has any ideas of things we could add that would be generally useful, let us know.

One that might be useful is a detailed status page with metrics. This is technically generic but can be used with Prometheus easily, and other systems with some work.

@boksasp
Copy link

boksasp commented Nov 21, 2024

Could you at least add json to the documentation? https://github.com/pelias/logger?tab=readme-ov-file#config.

I spent way too much time looking for how to enable this 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants